starlingx/test
Code Issues Proposed changes

Fix unit tests for app config after new apps added

Browse Source 
The commit 8bd43b6 added support for three new applications:
- power-manager (kubernetes-power-manager)
- node-feature-discovery
- node-interface-metrics-exporter

This broke unit tests because the custom test configuration file
was missing the new required fields. This fix:

- Adds missing app config fields to custom_app_config.json5
- Updates unit tests to validate all new getter methods
- Ensures complete test coverage for app configuration

Fixes: KeyError: 'power_manager_app_name' in test_custom_app_config

Change-Id: I0376a47b07ed53f6d2b34584986ce2ecd9b48214
Signed-off-by: Andrew Vaillancourt <andrew.vaillancourt@windriver.com>
This commit is contained in:
Andrew Vaillancourt
2025-07-10 18:13:51 -04:00
parent 6da8408968
commit 46d7a0ede4
2 changed files with 10 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

6
unit_tests/config/app/app_config_test.py
View File

@@ -18,6 +18,9 @@ def test_default_app_config():
assert default_config.get_metric_server_app_name() == "metrics-server", "metric server default name was incorrect"
assert default_config.get_oidc_app_name() == "oidc-auth-apps", "oidc default app name was incorrect"
assert default_config.get_power_metrics_app_name() == "power-metrics", "power metrics default app name was incorrect"
assert default_config.get_power_manager_app_name() == "kubernetes-power-manager", "power manager default app name was incorrect"
assert default_config.get_node_feature_discovery_app_name() == "node-feature-discovery", "node feature discovery default app name was incorrect"
assert default_config.get_node_interface_metrics_exporter_app_name() == "node-interface-metrics-exporter", "node interface metrics exporter default app name was incorrect"
def test_custom_app_config():
@@ -37,3 +40,6 @@ def test_custom_app_config():
assert custom_config.get_metric_server_app_name() == "metrics-server_custom", "metric server custom name was incorrect"
assert custom_config.get_oidc_app_name() == "oidc-auth-apps_custom", "oidc custom app name was incorrect"
assert custom_config.get_power_metrics_app_name() == "power-metrics_custom", "power metrics custom name was incorrect"
assert custom_config.get_power_manager_app_name() == "kubernetes-power-manager_custom", "power manager custom name was incorrect"
assert custom_config.get_node_feature_discovery_app_name() == "node-feature-discovery_custom", "node feature discovery custom name was incorrect"
assert custom_config.get_node_interface_metrics_exporter_app_name() == "node-interface-metrics-exporter_custom", "node interface metrics exporter custom name was incorrect"

5
unit_tests/config/app/custom_app_config.json5
View File

@@ -3,5 +3,8 @@
istio_app_name: "istio_custom",
metric_server_app_name: "metrics-server_custom",
oidc_app_name: "oidc-auth-apps_custom",
power_metrics_app_name: "power-metrics_custom"
power_metrics_app_name: "power-metrics_custom",
power_manager_app_name: "kubernetes-power-manager_custom",
node_feature_discovery_app_name: "node-feature-discovery_custom",
node_interface_metrics_exporter_app_name: "node-interface-metrics-exporter_custom"
}