starlingx/test
Code Issues Proposed changes

Add health check before subcloud backup creation

Browse Source 
The test_verify_backup_central_simplex was failing because it attempted
to create subcloud backups without validating subcloud health first.
The dcmanager backup command requires subclouds to be in good health
before backup creation can proceed.

This change adds health validation by establishing SSH connection to
the target subcloud and running validate_healty_cluster() to check
alarms, pods, and application status before attempting backup.

The fix prevents the "Subcloud must be in good health for
subcloud-backup create" error that was causing test failures.

Test Plan:
PASS: Verify health checks run before backup creation
PASS: Verify backup only proceeds when subcloud is healthy
PASS: Verify proper error handling for unhealthy subclouds

Change-Id: Iddba26c0edd294ce87104caf1bce298d18cd05ab
Signed-off-by: Abhishek jaiswal <abhishek.jaiswal@windriver.com>
This commit is contained in:
Abhishek jaiswal
2025-08-07 08:44:10 -04:00
parent e5bafaa0c8
commit 3b60df1d2b
1 changed files with 10 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

11
testcases/cloud_platform/regression/dc/backup_restore/test_verify_backup_file.py
View File

@@ -15,6 +15,7 @@ from keywords.cloud_platform.ssh.lab_connection_keywords import LabConnectionKey
from keywords.cloud_platform.version_info.cloud_platform_version_manager import CloudPlatformVersionManagerClass
from keywords.files.file_keywords import FileKeywords
from keywords.linux.date.date_keywords import DateKeywords
from keywords.cloud_platform.health.health_keywords import HealthKeywords
BACKUP_PATH = "/opt/dc-vault/backups/"
@@ -123,8 +124,16 @@ def test_verify_backup_central_simplex(request):
central_ssh = LabConnectionKeywords().get_active_controller_ssh()
dcm_sc_list_kw = DcManagerSubcloudListKeywords(central_ssh)
subcloud = dcm_sc_list_kw.get_dcmanager_subcloud_list().get_healthy_subcloud_by_type(LabTypeEnum.SIMPLEX.value)
subcloud_name = subcloud.get_name()
# get subcloud ssh
subcloud_ssh = LabConnectionKeywords().get_subcloud_ssh(subcloud_name)
# Prechecks Before Back-Up:
get_logger().log_info(f"Performing pre-checks on {subcloud_name}")
obj_health = HealthKeywords(subcloud_ssh)
obj_health.validate_healty_cluster() # Checks alarms, pods, app health
request.addfinalizer(teardown_central)
verify_backup_central(subcloud.get_name())
verify_backup_central(subcloud_name)
@mark.p0