openstack/sushy
Code Issues Proposed changes

Merge "Fix type of Targets in ShareParameters for Dell"

Browse Source
This commit is contained in:
Zuul
2025-06-02 12:23:10 +00:00
committed by Gerrit Code Review
parent 93218aba7e 075eac0669
commit 406c643260
3 changed files with 15 additions and 10 deletions
Download Patch File Download Diff File Expand all files Collapse all files

5
releasenotes/notes/bug-2111528-f126e9b00c056077.yaml Normal file
View File

@@ -0,0 +1,5 @@
---
fixes:
- |
Fix the Target property in the Dell OEM, it should be an array
as a value instead of a string.

4
sushy/oem/dell/resources/manager/manager.py
View File

@@ -83,7 +83,7 @@ class DellManagerExtension(oem_base.OEMResourceBase):
ACTION_DATA = {
'ShareParameters': {
'Target': 'ALL'
'Target': ['ALL']
},
'ImportBuffer': None
}
@@ -395,7 +395,7 @@ VFDD\
action_data = {
'ShareParameters': {
'Target': target
'Target': [target]
},
'ExportFormat': "JSON",
'ExportUse': export_use,

16
sushy/tests/oem/dell/unit/resources/manager/test_manager.py
View File

@@ -71,7 +71,7 @@ class ManagerTestCase(BaseTestCase):
self.conn.post.assert_called_once_with(
'/redfish/v1/Managers/iDRAC.Embedded.1/Actions/Oem/EID_674_Manager'
'.ImportSystemConfiguration',
data={'ShareParameters': {'Target': 'ALL'},
data={'ShareParameters': {'Target': ['ALL']},
'ImportBuffer':
'<SystemConfiguration><Component FQDD="iDRAC.Embedded.1">'
'<Attribute Name="ServerBoot.1#BootOnce">Enabled'
@@ -88,7 +88,7 @@ class ManagerTestCase(BaseTestCase):
self.conn.post.assert_called_once_with(
'/redfish/v1/Managers/iDRAC.Embedded.1/Actions/Oem/EID_674_Manager'
'.ImportSystemConfiguration',
data={'ShareParameters': {'Target': 'ALL'},
data={'ShareParameters': {'Target': ['ALL']},
'ImportBuffer':
'<SystemConfiguration><Component FQDD="iDRAC.Embedded.1">'
'<Attribute Name="ServerBoot.1#BootOnce">Enabled'
@@ -123,7 +123,7 @@ class ManagerTestCase(BaseTestCase):
self.conn.post.assert_called_with(
'/redfish/v1/Managers/iDRAC.Embedded.1/Actions/Oem/EID_674_Manager'
'.ImportSystemConfiguration',
data={'ShareParameters': {'Target': 'ALL'},
data={'ShareParameters': {'Target': ['ALL']},
'ImportBuffer':
'<SystemConfiguration><Component FQDD="iDRAC.Embedded.1">'
'<Attribute Name="ServerBoot.1#BootOnce">Enabled'
@@ -158,7 +158,7 @@ class ManagerTestCase(BaseTestCase):
self.conn.post.assert_called_with(
'/redfish/v1/Managers/iDRAC.Embedded.1/Actions/Oem/EID_674_Manager'
'.ImportSystemConfiguration',
data={'ShareParameters': {'Target': 'ALL'},
data={'ShareParameters': {'Target': ['ALL']},
'ImportBuffer':
'<SystemConfiguration><Component FQDD="iDRAC.Embedded.1">'
'<Attribute Name="ServerBoot.1#BootOnce">Enabled'
@@ -227,7 +227,7 @@ class ManagerTestCase(BaseTestCase):
self.conn.post.assert_called_once_with(
'/redfish/v1/Managers/iDRAC.Embedded.1/Actions/Oem/EID_674_Manager'
'.ExportSystemConfiguration', data={'ShareParameters':
{'Target': 'ALL'},
{'Target': ['ALL']},
'ExportFormat': 'JSON',
'ExportUse': 'Default',
'IncludeInExport': 'Default'})
@@ -244,7 +244,7 @@ class ManagerTestCase(BaseTestCase):
self.conn.post.assert_called_once_with(
'/redfish/v1/Managers/iDRAC.Embedded.1/Actions/Oem/EID_674_Manager'
'.ExportSystemConfiguration', data={'ShareParameters':
{'Target': 'RAID'},
{'Target': ['RAID']},
'ExportFormat': 'JSON',
'ExportUse': 'Clone',
'IncludeInExport':
@@ -309,7 +309,7 @@ class ManagerTestCase(BaseTestCase):
self.conn.post.assert_called_once_with(
'/redfish/v1/Managers/iDRAC.Embedded.1/Actions/Oem/EID_674_Manager'
'.ExportSystemConfiguration', data={'ShareParameters':
{'Target': 'RAID'},
{'Target': ['RAID']},
'ExportFormat': 'JSON',
'ExportUse': 'Clone',
'IncludeInExport':
@@ -552,7 +552,7 @@ class ManagerTestCase(BaseTestCase):
self.conn.post.assert_called_once_with(
'/redfish/v1/Managers/iDRAC.Embedded.1/Actions/Oem/EID_674_Manager'
'.ImportSystemConfiguration', data={'ShareParameters':
{'Target': 'ALL'},
{'Target': ['ALL']},
'ImportBuffer':
'{"key": "value"}',
'ShutdownType': 'NoReboot'})