openstack/puppet-designate
Code Issues Proposed changes

Remove deprecated behavior of enabled_notification_handlers

Browse Source 
Handling of a false value was deprecated during Yoga cycle[1].

[1] f87bd126b0

Change-Id: I9d96ba4bf12dd4c093aba55d7916598ff24f3327
This commit is contained in:
Takashi Kajinami
2022-08-28 23:00:14 +09:00
parent 406a78f867
commit a45b62e213
2 changed files with 7 additions and 9 deletions
Download Patch File Download Diff File Expand all files Collapse all files

10
manifests/sink.pp
View File

@@ -59,15 +59,7 @@ class designate::sink (
'service:sink/threads': value => $threads;
}
if ! $enabled_notification_handlers {
warning('Usage of false value for enabled_notification_handlers is deprecated. \
Use $::os_service_default instead')
$enabled_notification_handlers_real = $::os_service_default
} else {
$enabled_notification_handlers_real = $enabled_notification_handlers
}
designate_config {
'service:sink/enabled_notification_handlers': value => join(any2array($enabled_notification_handlers_real), ',')
'service:sink/enabled_notification_handlers': value => join(any2array($enabled_notification_handlers), ',')
}
}

6
releasenotes/notes/cleanup-enabled_notification_handlers-442dde7d553c41b9.yaml Normal file
View File

@@ -0,0 +1,6 @@
---
upgrade:
- |
The ``designate::sink::enabled_notification_handlers`` parameter no longer
treats a false value to unset the parameter. Use ``$::os_service_default``
instead of the service default should be used.