openstack/placement
Code Issues Proposed changes

Remove excessive logging from GET a_c

Browse Source 
The exceeds_capacity check is a hot spot during get
GET allocation_candidates query with multiple request groups.
So logging in that function is not practical as it slows down the query
and creates such amount of logs that can kill the service itself.

Closes-Bug: #2126438
Signed-off-by: Balazs Gibizer <gibi@redhat.com>
Change-Id: I2ac9b587a38e6c8e5b9af705c1e524c131b83214
Signed-off-by: Balazs Gibizer <gibi@redhat.com>
This commit is contained in:
Balazs Gibizer
2025-10-02 11:18:42 +02:00
parent 2df2316c37
commit 89bf1a232f
1 changed files with 4 additions and 10 deletions
Download Patch File Download Diff File Expand all files Collapse all files

14
placement/objects/research_context.py
View File

@@ -354,22 +354,16 @@ class RequestWideSearchContext(object):
`_consolidate_allocation_requests` method.
:return: True if areq exceeds capacity; False otherwise.
"""
# This is a hot spot, called potentially a million times during a
# GET allocation_candidates query. Please do not add logging in this
# function permanently as it will cause excessive logging.
for arr in areq.resource_requests:
key = (arr.resource_provider.id, arr.resource_class)
psum_res = self.psum_res_by_rp_rc[key]
if psum_res.used + arr.amount > psum_res.capacity:
LOG.debug('Excluding the following AllocationRequest because '
'used (%d) + amount (%d) > capacity (%d) for '
'resource class %s: %s',
psum_res.used, arr.amount, psum_res.capacity,
arr.resource_class, str(areq))
return True
if arr.amount > psum_res.max_unit:
LOG.debug('Excluding the following AllocationRequest because '
'amount (%d) > max_unit (%d) for resource class '
'%s: %s',
arr.amount, psum_res.max_unit, arr.resource_class,
str(areq))
return True
return False