Don't pause image build jobs in periodic buildset

Some clouds may not support number of nodes needed by buildset
in the case when affiliation is required.
Changing logic to avoid pausing build job before uploading to dockerhub
and promotion. This will also lead to uploading a temporary tag to
dockerhub prior test deployment is done.

Change-Id: I49ddd4c3992ce1e4c6a0e4a84374df920f308e56
Signed-off-by: Andrii Ostapenko <andrii.ostapenko@att.com>

zuul.d/alerta.yaml

@@ -24,6 +24,9 @@
     periodic:
       jobs:
         - openstack-helm-images-upload-alerta
+        - openstack-helm-images-promote-alerta:
+            dependencies:
+              - name: openstack-helm-images-aio-monitoring
 
 - job:
     name: openstack-helm-images-build-alerta

zuul.d/base.yaml

@@ -114,10 +114,6 @@
     run: zuul.d/playbooks/build.yml
     post-run:
       - zuul.d/playbooks/upload.yml
-      # Synthetic logic required with current implementation.
-      # Standalone promote job starts once upload one pauses that is undesired,
-      # thus running promote role here for periodic pipeline
-      - zuul.d/playbooks/periodic-promote.yml
     match-on-config-updates: false
     dependencies:
       - name: opendev-buildset-registry

zuul.d/elasticsearch-s3.yaml

@@ -24,6 +24,9 @@
     periodic:
       jobs:
         - openstack-helm-images-upload-elasticsearch-s3
+        - openstack-helm-images-promote-elasticsearch-s3:
+            dependencies:
+              - name: openstack-helm-images-aio-logging
 
 - job:
     name: openstack-helm-images-build-elasticsearch-s3

zuul.d/fluentd.yaml

@@ -24,6 +24,9 @@
     periodic:
       jobs:
         - openstack-helm-images-upload-fluentd
+        - openstack-helm-images-promote-fluentd:
+            dependencies:
+              - name: openstack-helm-images-aio-monitoring
 
 - job:
     name: openstack-helm-images-build-fluentd

zuul.d/libvirt.yaml

@@ -26,6 +26,10 @@
     periodic:
       jobs:
         - openstack-helm-images-upload-libvirt
+        - openstack-helm-images-promote-libvirt:
+            dependencies:
+              - name: openstack-helm-images-compute-kit-stein-ubuntu_bionic
+              - name: openstack-helm-images-compute-kit-train-ubuntu_bionic
 
 - job:
     name: openstack-helm-images-build-libvirt

zuul.d/mariadb.yaml

@@ -26,6 +26,12 @@
     periodic:
       jobs:
         - openstack-helm-images-upload-mariadb
+        - openstack-helm-images-promote-mariadb:
+            dependencies:
+              - name: openstack-helm-images-compute-kit-stein-ubuntu_bionic
+              - name: openstack-helm-images-compute-kit-train-ubuntu_bionic
+              - name: openstack-helm-images-cinder-stein-ubuntu_bionic
+              - name: openstack-helm-images-cinder-train-ubuntu_bionic
 
 - job:
     name: openstack-helm-images-build-mariadb

zuul.d/minikube-aio.yaml

@@ -24,6 +24,15 @@
     periodic:
       jobs:
         - openstack-helm-images-upload-minikube-aio
+        - openstack-helm-images-promote-minikube-aio:
+            dependencies:
+              - name: openstack-helm-images-aio-monitoring
+              - name: openstack-helm-images-aio-logging
+              - name: openstack-helm-images-compute-kit-stein-ubuntu_bionic
+              - name: openstack-helm-images-compute-kit-train-ubuntu_bionic
+              - name: openstack-helm-images-cinder-stein-ubuntu_bionic
+              - name: openstack-helm-images-cinder-train-ubuntu_bionic
+              - name: openstack-helm-images-horizon-stein-ubuntu_bionic
 
 - job:
     name: openstack-helm-images-build-minikube-aio

zuul.d/nagios.yaml

@@ -24,6 +24,9 @@
     periodic:
       jobs:
         - openstack-helm-images-upload-nagios
+        - openstack-helm-images-promote-nagios:
+            dependencies:
+              - name: openstack-helm-images-aio-monitoring
 
 - job:
     name: openstack-helm-images-build-nagios

zuul.d/node-problem-detector.yaml

@@ -24,6 +24,9 @@
     periodic:
       jobs:
         - openstack-helm-images-upload-node-problem-detector
+        - openstack-helm-images-promote-node-problem-detector:
+            dependencies:
+              - name: openstack-helm-images-aio-monitoring
 
 - job:
     name: openstack-helm-images-build-node-problem-detector

zuul.d/openstack-loci.yaml

@@ -55,7 +55,16 @@
         - openstack-helm-images-upload-openstack-loci-rocky-ubuntu_xenial
         - openstack-helm-images-upload-openstack-loci-rocky-ubuntu_bionic
         - openstack-helm-images-upload-openstack-loci-stein-ubuntu_bionic
+        - openstack-helm-images-promote-openstack-loci-stein-ubuntu_bionic:
+            dependencies:
+              - name: openstack-helm-images-compute-kit-stein-ubuntu_bionic
+              - name: openstack-helm-images-cinder-stein-ubuntu_bionic
+              - name: openstack-helm-images-horizon-stein-ubuntu_bionic
         - openstack-helm-images-upload-openstack-loci-train-ubuntu_bionic
+        - openstack-helm-images-promote-openstack-loci-train-ubuntu_bionic:
+            dependencies:
+              - name: openstack-helm-images-compute-kit-train-ubuntu_bionic
+              - name: openstack-helm-images-cinder-train-ubuntu_bionic
         - openstack-helm-images-upload-openstack-loci-ussuri-ubuntu_bionic
         - openstack-helm-images-upload-openstack-loci-master-ubuntu_bionic
 

zuul.d/openvswitch.yaml

@@ -26,6 +26,12 @@
     periodic:
       jobs:
         - openstack-helm-images-upload-openvswitch
+        - openstack-helm-images-promote-openvswitch:
+            dependencies:
+              - name: openstack-helm-images-compute-kit-stein-ubuntu_bionic
+              - name: openstack-helm-images-compute-kit-train-ubuntu_bionic
+              - name: openstack-helm-images-cinder-stein-ubuntu_bionic
+              - name: openstack-helm-images-cinder-train-ubuntu_bionic
 
 - job:
     name: openstack-helm-images-build-openvswitch

zuul.d/osh-selenium.yaml

@@ -26,6 +26,11 @@
     periodic:
       jobs:
         - openstack-helm-images-upload-osh-selenium
+        - openstack-helm-images-promote-osh-selenium:
+            dependencies:
+              - name: openstack-helm-images-aio-monitoring
+              - name: openstack-helm-images-aio-logging
+              - name: openstack-helm-images-horizon-stein-ubuntu_bionic
 
 - job:
     name: openstack-helm-images-build-osh-selenium

zuul.d/ospurge.yaml

@@ -26,6 +26,9 @@
     periodic:
       jobs:
         - openstack-helm-images-upload-ospurge
+        - openstack-helm-images-promote-ospurge:
+            dependencies:
+              - name: openstack-helm-images-compute-kit-stein-ubuntu_bionic
 
 - job:
     name: openstack-helm-images-build-ospurge

zuul.d/patroni.yaml

@@ -26,6 +26,9 @@
     periodic:
       jobs:
         - openstack-helm-images-upload-patroni
+        - openstack-helm-images-promote-patroni:
+            dependencies:
+              - name: openstack-helm-images-aio-monitoring
 
 - job:
     name: openstack-helm-images-build-patroni

zuul.d/playbooks/build-loci.yml

@@ -80,10 +80,3 @@
       loop: "{{ docker_images }}"
       loop_control:
         loop_var: zj_image
-
-    - name: Pause the job
-      when: buildset_registry is defined and zuul.pipeline != 'check'
-      zuul_return:
-        data:
-          zuul:
-            pause: true

zuul.d/playbooks/build.yml

@@ -11,9 +11,3 @@
       loop: "{{ docker_images }}"
       loop_control:
         loop_var: zj_image
-    - name: Pause the job
-      when: buildset_registry is defined and zuul.pipeline != 'check'
-      zuul_return:
-        data:
-          zuul:
-            pause: true

zuul.d/playbooks/periodic-promote.yml

@@ -1,4 +0,0 @@
-- hosts: all
-  roles:
-    - role: promote-docker-image
-      when: zuul.pipeline == 'periodic'

zuul.d/prometheus-openstack-exporter.yaml

@@ -24,6 +24,9 @@
     periodic:
       jobs:
         - openstack-helm-images-upload-prometheus-openstack-exporter
+        - openstack-helm-images-promote-prometheus-openstack-exporter:
+            dependencies:
+              - name: openstack-helm-images-aio-monitoring
 
 - job:
     name: openstack-helm-images-build-prometheus-openstack-exporter