Merge "Require valid volume size"

octavia/common/config.py

@@ -760,7 +760,7 @@ cinder_opts = [
     cfg.BoolOpt('insecure',
                 default=False,
                 help=_('Disable certificate validation on SSL connections')),
-    cfg.IntOpt('volume_size', default=16,
+    cfg.IntOpt('volume_size', default=16, min=1,
                help=_('Size of volume, in GB, for Amphora instance')),
     cfg.StrOpt('volume_type', default=None,
                help=_('Type of volume for Amphorae volume root disk')),

releasenotes/notes/min-volume-size-6ea9c69182b325bd.yaml

@@ -0,0 +1,7 @@
+---
+fixes:
+  - |
+    The ``[cinder] volume_size`` option no longer accepts 0 or a negative value
+    and octavia services may fail to start when these values are used.
+    These were accepted previously but caused an internal error when a volume
+    is actually created.