openstack/nova
Code Issues Proposed changes

Store "null api version" as 0.0

Browse Source 
Nova API doesn't have 0 version, so we can use 0.0 for Null APIVersion.
It will help to write simple comparison methods.

Change-Id: I9010007e6e5a92a378299ccb0d674b30fdabc365
This commit is contained in:
Andrey Kurilin
2015-08-14 16:58:12 +03:00
parent 05dbd82a10
commit c6c3d7c314
1 changed files with 10 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files

14
nova/api/openstack/api_version_request.py
View File

@@ -81,9 +81,15 @@ class APIVersionRequest(object):
"""
def __init__(self, version_string=None):
"""Create an API version request object."""
self.ver_major = None
self.ver_minor = None
"""Create an API version request object.
:param version_string: String representation of APIVersionRequest.
Correct format is 'X.Y', where 'X' and 'Y' are int values.
None value should be used to create Null APIVersionRequest,
which is equal to 0.0
"""
self.ver_major = 0
self.ver_minor = 0
if version_string is not None:
match = re.match(r"^([1-9]\d*)\.([1-9]\d*|0)$",
@@ -100,7 +106,7 @@ class APIVersionRequest(object):
% (self.ver_major, self.ver_minor))
def is_null(self):
return self.ver_major is None and self.ver_minor is None
return self.ver_major == 0 and self.ver_minor == 0
def __cmp__(self, other):
if not isinstance(other, APIVersionRequest):