openstack/nova
Code Issues Proposed changes

Merge "Return 400 when name is more than 255 characters"

Browse Source
This commit is contained in:
Jenkins
2017-01-04 21:32:41 +00:00
committed by Gerrit Code Review
parent 7f05ff7850 874e666e7a
commit c61fd0078d
2 changed files with 21 additions and 0 deletions
Download Patch File Download Diff File Expand all files Collapse all files

1
nova/api/openstack/placement/handlers/resource_class.py
View File

@@ -29,6 +29,7 @@ POST_RC_SCHEMA_V1_2 = {
"name": {
"type": "string",
"pattern": "^CUSTOM\_[A-Z0-9_]+$",
"maxLength": 255,
},
},
"required": [

20
nova/tests/functional/api/openstack/placement/gabbits/resource-classes.yaml
View File

@@ -195,3 +195,23 @@ tests:
status: 400
response_strings:
- JSON does not validate
- name: try to create resource class with name exceed max characters
POST: /resource_classes
request_headers:
content-type: application/json
data:
name: &name_exceeds_max_length_check CUSTOM_THIS_IS_A_LONG_TEXT_OF_LENGTH_256_CHARACTERSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSS
status: 400
response_strings:
- "Failed validating 'maxLength'"
- name: try to update resource class with name exceed max characters
PUT: /resource_classes/$ENVIRON['CUSTOM_RES_CLASS']
request_headers:
content-type: application/json
data:
name: *name_exceeds_max_length_check
status: 400
response_strings:
- "Failed validating 'maxLength'"