openstack/nova
Code Issues Proposed changes

Merge "Log stack trace when fails launching a defined domain"

Browse Source
This commit is contained in:
Zuul
2020-10-06 00:30:47 +00:00
committed by Gerrit Code Review
parent 43801cf24a 73cc85d910
commit 07c68e45dd
2 changed files with 3 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
nova/tests/unit/virt/libvirt/test_guest.py
View File

@@ -80,7 +80,7 @@ class GuestTestCase(test.NoDBTestCase):
self.domain.createWithFlags.assert_called_once_with(
fakelibvirt.VIR_DOMAIN_START_PAUSED)
@mock.patch.object(libvirt_guest.LOG, 'error')
@mock.patch.object(libvirt_guest.LOG, 'exception')
@mock.patch.object(encodeutils, 'safe_decode')
def test_launch_exception(self, mock_safe_decode, mock_log):
fake_xml = '<test>this is a test</test>'

5
nova/virt/libvirt/guest.py
View File

@@ -155,9 +155,8 @@ class Guest(object):
return self._domain.createWithFlags(flags)
except Exception:
with excutils.save_and_reraise_exception():
LOG.error('Error launching a defined domain '
'with XML: %s',
self._encoded_xml, errors='ignore')
LOG.exception('Error launching a defined domain with XML: %s',
self._encoded_xml, errors='ignore')
def poweroff(self):
"""Stops a running guest."""