openstack/neutron-lib
Code Issues Proposed changes

Merge "Doc olso config option approach"

Browse Source
This commit is contained in:
Jenkins
2016-12-28 10:00:53 +00:00
committed by Gerrit Code Review
parent 36ebf95938 3225a572b7
commit bd9acbf387
1 changed files with 10 additions and 0 deletions
Download Patch File Download Diff File Expand all files Collapse all files

10
doc/source/review-guidelines.rst
View File

@@ -67,3 +67,13 @@ When reviewing neutron-lib changes, please be aware:
moved into neutron-lib:
- eventlet
* With respect to `Oslo config options <http://docs.openstack.org/developer/oslo.config/>`_:
- Config options should only be included in neutron-lib when the respective
functionality that uses the options lives in neutron-lib. In this case the
options will need to be exposed as entry points for
`config generation <http://docs.openstack.org/developer/oslo.config/generator.html>`_.
- Common functionality in neutron-lib that accesses config values should
assume the caller has registered them and document such in the docstring for
the respective functionality in neutron-lib.