zuul/zuul-jobs
Code Issues Proposed changes

Merge "Remove version defaults for nodejs jobs"

Browse Source
This commit is contained in:
Zuul
2025-09-10 13:18:34 +00:00
committed by Gerrit Code Review
parent f377cfb73c 28607bbc26
commit ca4935d71c
3 changed files with 2 additions and 17 deletions
Download Patch File Download Diff File Expand all files Collapse all files

1
roles/ensure-javascript-build-tool/defaults/main.yaml
View File

@@ -1,2 +1 @@
node_version: '14'
zuul_work_dir: "{{ zuul.project.src_dir }}" zuul_work_dir: "{{ zuul.project.src_dir }}"

15
zuul.d/js-jobs.yaml
View File

@@ -19,7 +19,6 @@
Command to use for running the package manager, such as npm or yarn. Command to use for running the package manager, such as npm or yarn.
.. zuul:jobvar:: node_version .. zuul:jobvar:: node_version
:default: 14
The version of Node to use. The version of Node to use.
@@ -37,7 +36,6 @@
post-run: playbooks/javascript/post.yaml post-run: playbooks/javascript/post.yaml
vars: vars:
js_build_command: build js_build_command: build
node_version: 14
- job: - job:
name: build-javascript-source-tarball name: build-javascript-source-tarball
@@ -48,7 +46,6 @@
Responds to these variables: Responds to these variables:
.. zuul:jobvar:: node_version .. zuul:jobvar:: node_version
:default: 14
The version of Node to use. The version of Node to use.
@@ -80,7 +77,6 @@
Command to pass to npm. Command to pass to npm.
.. zuul:jobvar:: node_version .. zuul:jobvar:: node_version
:default: 14
The version of Node to use. The version of Node to use.
@@ -114,7 +110,6 @@
Command to use for running the package manager, such as npm or yarn. Command to use for running the package manager, such as npm or yarn.
.. zuul:jobvar:: node_version .. zuul:jobvar:: node_version
:default: 20
The version of Node to use. Netlify CLI requires at least v18. The version of Node to use. Netlify CLI requires at least v18.
@@ -145,8 +140,6 @@
a token can be found at a token can be found at
https://docs.netlify.com/cli/get-started/#obtain-a-token-in-the-netlify-ui https://docs.netlify.com/cli/get-started/#obtain-a-token-in-the-netlify-ui
post-run: playbooks/javascript/netlify-publish.yaml post-run: playbooks/javascript/netlify-publish.yaml
vars:
node_version: 20
- job: - job:
name: nodejs-run-test name: nodejs-run-test
@@ -157,9 +150,8 @@
Responds to these variables: Responds to these variables:
.. zuul:jobvar:: node_version .. zuul:jobvar:: node_version
:default: 14
The version of Node to use. The version of Node to use.
.. zuul:jobvar:: zuul_work_dir .. zuul:jobvar:: zuul_work_dir
:default: {{ zuul.project.src_dir }} :default: {{ zuul.project.src_dir }}
@@ -183,9 +175,8 @@
Responds to these variables: Responds to these variables:
.. zuul:jobvar:: node_version .. zuul:jobvar:: node_version
:default: 14
The version of Node to use. The version of Node to use.
.. zuul:jobvar:: zuul_work_dir .. zuul:jobvar:: zuul_work_dir
:default: {{ zuul.project.src_dir }} :default: {{ zuul.project.src_dir }}
@@ -209,7 +200,6 @@
Responds to these variables: Responds to these variables:
.. zuul:jobvar:: node_version .. zuul:jobvar:: node_version
:default: 14
The version of Node to use. The version of Node to use.
@@ -234,7 +224,6 @@
Responds to these variables: Responds to these variables:
.. zuul:jobvar:: node_version .. zuul:jobvar:: node_version
:default: 14
The version of Node to use. The version of Node to use.

3
zuul.d/python-jobs.yaml
View File

@@ -327,7 +327,6 @@
Command to pass to npm. Command to pass to npm.
.. zuul:jobvar:: node_version .. zuul:jobvar:: node_version
:default: 14
The version of Node to use. The version of Node to use.
@@ -632,5 +631,3 @@
`.markdownlint.json` that is configured according to `.markdownlint.json` that is configured according to
https://github.com/DavidAnson/markdownlint#optionsconfig https://github.com/DavidAnson/markdownlint#optionsconfig
to control rule specifics. to control rule specifics.
vars:
node_version: 18