9c5bc99b5c
Based on current implement, some href-template of homedoc
are returning absolute path ('/queues'...). It may cause
a 404 error because client may join a host with the path
directly. This patch will make sure all the href-template
start with /v1 and add unit test case to make url joining
works well.
Fixes bug 1245656
Change-Id: I12059249135cdb82be7d1937cf65db5da860011b
61 lines
2.0 KiB
Python
61 lines
2.0 KiB
Python
# Copyright (c) 2013 Rackspace, Inc.
|
|
#
|
|
# Licensed under the Apache License, Version 2.0 (the "License");
|
|
# you may not use this file except in compliance with the License.
|
|
# You may obtain a copy of the License at
|
|
#
|
|
# http://www.apache.org/licenses/LICENSE-2.0
|
|
#
|
|
# Unless required by applicable law or agreed to in writing, software
|
|
# distributed under the License is distributed on an "AS IS" BASIS,
|
|
# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or
|
|
# implied.
|
|
#
|
|
# See the License for the specific language governing permissions and
|
|
# limitations under the License.
|
|
|
|
import json
|
|
import urlparse
|
|
|
|
import falcon
|
|
|
|
from . import base # noqa
|
|
|
|
|
|
class TestHomeDocument(base.TestBase):
|
|
|
|
config_file = 'wsgi_sqlite.conf'
|
|
|
|
def test_json_response(self):
|
|
body = self.simulate_get('/v1')
|
|
self.assertEqual(self.srmock.status, falcon.HTTP_200)
|
|
|
|
content_type = self.srmock.headers_dict['Content-Type']
|
|
self.assertEqual(content_type, 'application/json-home')
|
|
|
|
try:
|
|
json.loads(body[0])
|
|
except ValueError:
|
|
self.fail('Home document is not valid JSON')
|
|
|
|
def test_href_template(self):
|
|
body = self.simulate_get('/v1')
|
|
self.assertEqual(self.srmock.status, falcon.HTTP_200)
|
|
resp = json.loads(body[0])
|
|
queue_href_template = resp['resources']['rel/queue']['href-template']
|
|
path_1 = 'https://marconi.example.com/v1'
|
|
path_2 = 'https://marconi.example.com/v1/'
|
|
|
|
# verify all the href template start with /v1
|
|
for resource in list(resp['resources']):
|
|
self.assertTrue(resp['resources'][resource]['href-template'].
|
|
startswith('/v1'))
|
|
|
|
url = urlparse.urljoin(path_1, queue_href_template)
|
|
self.assertEqual(url.format(queue_name='foo'),
|
|
'https://marconi.example.com/v1/queues/foo')
|
|
|
|
url = urlparse.urljoin(path_2, queue_href_template)
|
|
self.assertEqual(url.format(queue_name='foo'),
|
|
'https://marconi.example.com/v1/queues/foo')
|