diff --git a/doc/source/cli/index.rst b/doc/source/cli/index.rst index a734a4eac2..40f6b87c5e 100644 --- a/doc/source/cli/index.rst +++ b/doc/source/cli/index.rst @@ -6,3 +6,4 @@ :maxdepth: 1 trove-manage + trove-status diff --git a/doc/source/cli/trove-status.rst b/doc/source/cli/trove-status.rst new file mode 100644 index 0000000000..aa01f2d4f8 --- /dev/null +++ b/doc/source/cli/trove-status.rst @@ -0,0 +1,78 @@ +============ +trove-status +============ + +Synopsis +======== + +:: + + trove-status [] + +Description +=========== + +:program:`trove-status` is a tool that provides routines for checking the +status of a Trove deployment. + +Options +======= + +The standard pattern for executing a :program:`trove-status` command is:: + + trove-status [] + +Run without arguments to see a list of available command categories:: + + trove-status + +Categories are: + +* ``upgrade`` + +Detailed descriptions are below. + +You can also run with a category argument such as ``upgrade`` to see a list of +all commands in that category:: + + trove-status upgrade + +These sections describe the available categories and arguments for +:program:`trove-status`. + +Upgrade +~~~~~~~ + +.. _trove-status-checks: + +``trove-status upgrade check`` + Performs a release-specific readiness check before restarting services with + new code. This command expects to have complete configuration and access + to databases and services. + + **Return Codes** + + .. list-table:: + :widths: 20 80 + :header-rows: 1 + + * - Return code + - Description + * - 0 + - All upgrade readiness checks passed successfully and there is nothing + to do. + * - 1 + - At least one check encountered an issue and requires further + investigation. This is considered a warning but the upgrade may be OK. + * - 2 + - There was an upgrade status check failure that needs to be + investigated. This should be considered something that stops an + upgrade. + * - 255 + - An unexpected error occurred. + + **History of Checks** + + **11.0.0 (Stein)** + + * Placeholder to be filled in with checks as they are added in Stein. diff --git a/lower-constraints.txt b/lower-constraints.txt index 6441ba199d..8412d23049 100644 --- a/lower-constraints.txt +++ b/lower-constraints.txt @@ -87,6 +87,7 @@ oslo.middleware==3.31.0 oslo.policy==1.30.0 oslo.serialization==2.18.0 oslo.service==1.24.0 +oslo.upgradecheck==0.1.0 oslo.utils==3.33.0 osprofiler==1.4.0 packaging==17.1 diff --git a/releasenotes/notes/trove-status-upgrade-check-framework-b9d3d3e2463ec26d.yaml b/releasenotes/notes/trove-status-upgrade-check-framework-b9d3d3e2463ec26d.yaml new file mode 100644 index 0000000000..0e595a9620 --- /dev/null +++ b/releasenotes/notes/trove-status-upgrade-check-framework-b9d3d3e2463ec26d.yaml @@ -0,0 +1,13 @@ +--- +prelude: > + Added new tool ``trove-status upgrade check``. +features: + - | + New framework for ``trove-status upgrade check`` command is added. + This framework allows adding various checks which can be run before a + Trove upgrade to ensure if the upgrade can be performed safely. +upgrade: + - | + Operator can now use new CLI tool ``trove-status upgrade check`` + to check if Trove deployment can be safely upgraded from + N-1 to N release. diff --git a/requirements.txt b/requirements.txt index 083ef63220..a386515fa2 100644 --- a/requirements.txt +++ b/requirements.txt @@ -32,6 +32,7 @@ oslo.i18n>=3.15.3 # Apache-2.0 oslo.middleware>=3.31.0 # Apache-2.0 oslo.serialization!=2.19.1,>=2.18.0 # Apache-2.0 oslo.service!=1.28.1,>=1.24.0 # Apache-2.0 +oslo.upgradecheck>=0.1.0 # Apache-2.0 oslo.utils>=3.33.0 # Apache-2.0 oslo.concurrency>=3.26.0 # Apache-2.0 PyMySQL>=0.7.6 # MIT License diff --git a/setup.cfg b/setup.cfg index c49ab99bc3..685366daf9 100644 --- a/setup.cfg +++ b/setup.cfg @@ -34,6 +34,7 @@ console_scripts = trove-manage = trove.cmd.manage:main trove-guestagent = trove.cmd.guest:main trove-fake-mode = trove.cmd.fakemode:main + trove-status = trove.cmd.status:main trove.api.extensions = account = trove.extensions.routes.account:Account diff --git a/trove/cmd/status.py b/trove/cmd/status.py new file mode 100644 index 0000000000..da00f675e2 --- /dev/null +++ b/trove/cmd/status.py @@ -0,0 +1,52 @@ +# Copyright (c) 2018 NEC, Corp. +# +# Licensed under the Apache License, Version 2.0 (the "License"); you may +# not use this file except in compliance with the License. You may obtain +# a copy of the License at +# +# http://www.apache.org/licenses/LICENSE-2.0 +# +# Unless required by applicable law or agreed to in writing, software +# distributed under the License is distributed on an "AS IS" BASIS, WITHOUT +# WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the +# License for the specific language governing permissions and limitations +# under the License. + +import sys + +from oslo_config import cfg +from oslo_upgradecheck import upgradecheck + +from trove.common.i18n import _ + + +class Checks(upgradecheck.UpgradeCommands): + + """Various upgrade checks should be added as separate methods in this class + and added to _upgrade_checks tuple. + """ + + def _check_placeholder(self): + # This is just a placeholder for upgrade checks, it should be + # removed when the actual checks are added + return upgradecheck.Result(upgradecheck.Code.SUCCESS) + + # The format of the check functions is to return an + # oslo_upgradecheck.upgradecheck.Result + # object with the appropriate + # oslo_upgradecheck.upgradecheck.Code and details set. + # If the check hits warnings or failures then those should be stored + # in the returned Result's "details" attribute. The + # summary will be rolled up at the end of the check() method. + _upgrade_checks = ( + # In the future there should be some real checks added here + (_('Placeholder'), _check_placeholder), + ) + + +def main(): + return upgradecheck.main( + cfg.CONF, project='trove', upgrade_command=Checks()) + +if __name__ == '__main__': + sys.exit(main()) diff --git a/trove/tests/unittests/cmd/__init__.py b/trove/tests/unittests/cmd/__init__.py new file mode 100644 index 0000000000..e69de29bb2 diff --git a/trove/tests/unittests/cmd/test_status.py b/trove/tests/unittests/cmd/test_status.py new file mode 100644 index 0000000000..0b3ca1e4b9 --- /dev/null +++ b/trove/tests/unittests/cmd/test_status.py @@ -0,0 +1,30 @@ +# Copyright (c) 2018 NEC, Corp. +# +# Licensed under the Apache License, Version 2.0 (the "License"); you may +# not use this file except in compliance with the License. You may obtain +# a copy of the License at +# +# http://www.apache.org/licenses/LICENSE-2.0 +# +# Unless required by applicable law or agreed to in writing, software +# distributed under the License is distributed on an "AS IS" BASIS, WITHOUT +# WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the +# License for the specific language governing permissions and limitations +# under the License. + +from oslo_upgradecheck.upgradecheck import Code + +from trove.cmd import status +from trove.tests.unittests import trove_testtools + + +class TestUpgradeChecks(trove_testtools.TestCase): + + def setUp(self): + super(TestUpgradeChecks, self).setUp() + self.cmd = status.Checks() + + def test__check_placeholder(self): + check_result = self.cmd._check_placeholder() + self.assertEqual( + Code.SUCCESS, check_result.code)