diff --git a/releasenotes/notes/bug-2111528-f126e9b00c056077.yaml b/releasenotes/notes/bug-2111528-f126e9b00c056077.yaml new file mode 100644 index 00000000..c9118ff0 --- /dev/null +++ b/releasenotes/notes/bug-2111528-f126e9b00c056077.yaml @@ -0,0 +1,5 @@ +--- +fixes: + - | + Fix the Target property in the Dell OEM, it should be an array + as a value instead of a string. diff --git a/sushy/oem/dell/resources/manager/manager.py b/sushy/oem/dell/resources/manager/manager.py index 605d25d7..dd34ca1b 100644 --- a/sushy/oem/dell/resources/manager/manager.py +++ b/sushy/oem/dell/resources/manager/manager.py @@ -83,7 +83,7 @@ class DellManagerExtension(oem_base.OEMResourceBase): ACTION_DATA = { 'ShareParameters': { - 'Target': 'ALL' + 'Target': ['ALL'] }, 'ImportBuffer': None } @@ -395,7 +395,7 @@ VFDD\ action_data = { 'ShareParameters': { - 'Target': target + 'Target': [target] }, 'ExportFormat': "JSON", 'ExportUse': export_use, diff --git a/sushy/tests/oem/dell/unit/resources/manager/test_manager.py b/sushy/tests/oem/dell/unit/resources/manager/test_manager.py index e2e6a95a..1e980938 100644 --- a/sushy/tests/oem/dell/unit/resources/manager/test_manager.py +++ b/sushy/tests/oem/dell/unit/resources/manager/test_manager.py @@ -71,7 +71,7 @@ class ManagerTestCase(BaseTestCase): self.conn.post.assert_called_once_with( '/redfish/v1/Managers/iDRAC.Embedded.1/Actions/Oem/EID_674_Manager' '.ImportSystemConfiguration', - data={'ShareParameters': {'Target': 'ALL'}, + data={'ShareParameters': {'Target': ['ALL']}, 'ImportBuffer': '' 'Enabled' @@ -88,7 +88,7 @@ class ManagerTestCase(BaseTestCase): self.conn.post.assert_called_once_with( '/redfish/v1/Managers/iDRAC.Embedded.1/Actions/Oem/EID_674_Manager' '.ImportSystemConfiguration', - data={'ShareParameters': {'Target': 'ALL'}, + data={'ShareParameters': {'Target': ['ALL']}, 'ImportBuffer': '' 'Enabled' @@ -123,7 +123,7 @@ class ManagerTestCase(BaseTestCase): self.conn.post.assert_called_with( '/redfish/v1/Managers/iDRAC.Embedded.1/Actions/Oem/EID_674_Manager' '.ImportSystemConfiguration', - data={'ShareParameters': {'Target': 'ALL'}, + data={'ShareParameters': {'Target': ['ALL']}, 'ImportBuffer': '' 'Enabled' @@ -158,7 +158,7 @@ class ManagerTestCase(BaseTestCase): self.conn.post.assert_called_with( '/redfish/v1/Managers/iDRAC.Embedded.1/Actions/Oem/EID_674_Manager' '.ImportSystemConfiguration', - data={'ShareParameters': {'Target': 'ALL'}, + data={'ShareParameters': {'Target': ['ALL']}, 'ImportBuffer': '' 'Enabled' @@ -227,7 +227,7 @@ class ManagerTestCase(BaseTestCase): self.conn.post.assert_called_once_with( '/redfish/v1/Managers/iDRAC.Embedded.1/Actions/Oem/EID_674_Manager' '.ExportSystemConfiguration', data={'ShareParameters': - {'Target': 'ALL'}, + {'Target': ['ALL']}, 'ExportFormat': 'JSON', 'ExportUse': 'Default', 'IncludeInExport': 'Default'}) @@ -244,7 +244,7 @@ class ManagerTestCase(BaseTestCase): self.conn.post.assert_called_once_with( '/redfish/v1/Managers/iDRAC.Embedded.1/Actions/Oem/EID_674_Manager' '.ExportSystemConfiguration', data={'ShareParameters': - {'Target': 'RAID'}, + {'Target': ['RAID']}, 'ExportFormat': 'JSON', 'ExportUse': 'Clone', 'IncludeInExport': @@ -309,7 +309,7 @@ class ManagerTestCase(BaseTestCase): self.conn.post.assert_called_once_with( '/redfish/v1/Managers/iDRAC.Embedded.1/Actions/Oem/EID_674_Manager' '.ExportSystemConfiguration', data={'ShareParameters': - {'Target': 'RAID'}, + {'Target': ['RAID']}, 'ExportFormat': 'JSON', 'ExportUse': 'Clone', 'IncludeInExport': @@ -552,7 +552,7 @@ class ManagerTestCase(BaseTestCase): self.conn.post.assert_called_once_with( '/redfish/v1/Managers/iDRAC.Embedded.1/Actions/Oem/EID_674_Manager' '.ImportSystemConfiguration', data={'ShareParameters': - {'Target': 'ALL'}, + {'Target': ['ALL']}, 'ImportBuffer': '{"key": "value"}', 'ShutdownType': 'NoReboot'})