Merge "Validate ensure parameter for package resources"

manifests/api.pp

@@ -65,7 +65,7 @@ class mistral::api (
   $bind_port                              = $facts['os_service_default'],
   Boolean $enabled                        = true,
   Boolean $manage_service                 = true,
-  $package_ensure                  = present,
+  Stdlib::Ensure::Package $package_ensure = present,
   $service_name                           = $mistral::params::api_service_name,
   $enable_proxy_headers_parsing           = $facts['os_service_default'],
   $max_request_body_size                  = $facts['os_service_default'],

manifests/client.pp

@@ -8,7 +8,7 @@
 #   Ensure state for package. Defaults to 'present'.
 #
 class mistral::client (
-  $package_ensure = 'present'
+  Stdlib::Ensure::Package $package_ensure = present,
 ) {
   include mistral::deps
   include mistral::params

manifests/engine.pp

@@ -53,7 +53,7 @@
 #   Defaults to $facts['os_service_default'].
 #
 class mistral::engine (
-  $package_ensure                       = present,
+  Stdlib::Ensure::Package $package_ensure = present,
   Boolean $manage_service                 = true,
   Boolean $enabled                        = true,
   $host                                   = $facts['os_service_default'],

manifests/event_engine.pp

@@ -29,7 +29,7 @@
 #   Defaults to $facts['os_service_default'].
 #
 class mistral::event_engine (
-  $package_ensure                = present,
+  Stdlib::Ensure::Package $package_ensure = present,
   Boolean $manage_service                 = true,
   Boolean $enabled                        = true,
   $host                                   = $facts['os_service_default'],

manifests/executor.pp

@@ -36,7 +36,7 @@
 #   Defaults to $facts['os_service_default'].
 #
 class mistral::executor (
-  $package_ensure               = present,
+  Stdlib::Ensure::Package $package_ensure = present,
   Boolean $manage_service                 = true,
   Boolean $enabled                        = true,
   Enum['local', 'remote'] $type           = 'remote',

manifests/init.pp

@@ -194,7 +194,7 @@
 #   Defaults to $facts['os_service_default']
 #
 class mistral (
-  $package_ensure                     = 'present',
+  Stdlib::Ensure::Package $package_ensure = present,
   $os_actions_endpoint_type               = $facts['os_service_default'],
   $control_exchange                       = $facts['os_service_default'],
   $rpc_response_timeout                   = $facts['os_service_default'],

manifests/notifier.pp

@@ -42,7 +42,7 @@
 #   Defaults to $facts['os_service_default'].
 #
 class mistral::notifier (
-  $package_ensure               = present,
+  Stdlib::Ensure::Package $package_ensure = present,
   Boolean $manage_service                 = true,
   Boolean $enabled                        = true,
   Enum['local', 'remote'] $type           = 'remote',

metadata.json

@@ -7,7 +7,7 @@
         },
         {
             "name": "puppetlabs/stdlib",
-            "version_requirement": ">=5.0.0 <10.0.0"
+            "version_requirement": ">=9.0.0 <10.0.0"
         },
         {
             "name": "openstack/keystone",