From e67e26e27ad5b62bd1440bb2694da2def3799f58 Mon Sep 17 00:00:00 2001
From: Takashi Kajinami <tkajinam@redhat.com>
Date: Mon, 4 May 2020 01:11:06 +0900
Subject: [PATCH] Add common test cases for cinder_config resource

Change-Id: I19fa59b387079db43e5268acc7a8934ea3120bb3
---
 ...e_spec.rb => cinder_api_paste_ini_spec.rb} | 16 ++-----
 spec/unit/type/cinder_config_spec.rb          | 45 +++++++++++++++++++
 2 files changed, 48 insertions(+), 13 deletions(-)
 rename spec/unit/type/{cinder_api_paste_spec.rb => cinder_api_paste_ini_spec.rb} (75%)

diff --git a/spec/unit/type/cinder_api_paste_spec.rb b/spec/unit/type/cinder_api_paste_ini_spec.rb
similarity index 75%
rename from spec/unit/type/cinder_api_paste_spec.rb
rename to spec/unit/type/cinder_api_paste_ini_spec.rb
index 4a76b291..979a38d9 100644
--- a/spec/unit/type/cinder_api_paste_spec.rb
+++ b/spec/unit/type/cinder_api_paste_ini_spec.rb
@@ -1,21 +1,11 @@
-require 'spec_helper'
-# this hack is required for now to ensure that the path is set up correctly
-# to retrieve the parent provider
-$LOAD_PATH.push(
-  File.join(
-    File.dirname(__FILE__),
-    '..',
-    '..',
-    'fixtures',
-    'modules',
-    'inifile',
-    'lib')
-)
+require 'puppet'
 require 'puppet/type/cinder_api_paste_ini'
+
 describe 'Puppet::Type.type(:cinder_api_paste_ini)' do
   before :each do
     @cinder_api_paste_ini = Puppet::Type.type(:cinder_api_paste_ini).new(:name => 'DEFAULT/foo', :value => 'bar')
   end
+
   it 'should accept a valid value' do
     @cinder_api_paste_ini[:value] = 'bar'
     expect(@cinder_api_paste_ini[:value]).to eq('bar')
diff --git a/spec/unit/type/cinder_config_spec.rb b/spec/unit/type/cinder_config_spec.rb
index 130460cf..169d38b9 100644
--- a/spec/unit/type/cinder_config_spec.rb
+++ b/spec/unit/type/cinder_config_spec.rb
@@ -6,6 +6,51 @@ describe 'Puppet::Type.type(:cinder_config)' do
     @cinder_config = Puppet::Type.type(:cinder_config).new(:name => 'DEFAULT/foo', :value => 'bar')
   end
 
+  it 'should require a name' do
+    expect {
+      Puppet::Type.type(:cinder_config).new({})
+    }.to raise_error(Puppet::Error, 'Title or name must be provided')
+  end
+
+  it 'should not expect a name with whitespace' do
+    expect {
+      Puppet::Type.type(:cinder_config).new(:name => 'f oo')
+    }.to raise_error(Puppet::Error, /Parameter name failed/)
+  end
+
+  it 'should fail when there is no section' do
+    expect {
+      Puppet::Type.type(:cinder_config).new(:name => 'foo')
+    }.to raise_error(Puppet::Error, /Parameter name failed/)
+  end
+
+  it 'should not require a value when ensure is absent' do
+    Puppet::Type.type(:cinder_config).new(:name => 'DEFAULT/foo', :ensure => :absent)
+  end
+
+  it 'should accept a valid value' do
+    @cinder_config[:value] = 'bar'
+    expect(@cinder_config[:value]).to eq('bar')
+  end
+
+  it 'should not accept a value with whitespace' do
+    @cinder_config[:value] = 'b ar'
+    expect(@cinder_config[:value]).to eq('b ar')
+  end
+
+  it 'should accept valid ensure values' do
+    @cinder_config[:ensure] = :present
+    expect(@cinder_config[:ensure]).to eq(:present)
+    @cinder_config[:ensure] = :absent
+    expect(@cinder_config[:ensure]).to eq(:absent)
+  end
+
+  it 'should not accept invalid ensure values' do
+    expect {
+      @cinder_config[:ensure] = :latest
+    }.to raise_error(Puppet::Error, /Invalid value/)
+  end
+
   it 'should autorequire the package that install the file' do
     catalog = Puppet::Resource::Catalog.new
     anchor = Puppet::Type.type(:anchor).new(:name => 'cinder::install::end')