From fdb962758c24698c89fe2ac7bc27182697c35d40 Mon Sep 17 00:00:00 2001 From: Graham Hayes Date: Mon, 21 Mar 2016 12:08:57 +0000 Subject: [PATCH] Create 'Review-Priority' for designate repos This allows anyone in the group "designate-release-manager" to set the priority of patches, and block non freeze patches during RC. This allows for more precise dashboard than relying on stars from PTLs, and allows the team to distingush between a procedural -2 and a release freeze -2. Change-Id: Id7b4c6b219899fa7ed86554257264af7efe20408 --- gerrit/acls/openstack/designate-dashboard.config | 13 +++++++++++++ gerrit/acls/openstack/designate-specs.config | 13 +++++++++++++ .../acls/openstack/designate-tempest-plugin.config | 13 +++++++++++++ gerrit/acls/openstack/designate.config | 13 +++++++++++++ gerrit/acls/openstack/python-designateclient.config | 13 +++++++++++++ tools/normalize_acl.py | 4 ++++ 6 files changed, 69 insertions(+) diff --git a/gerrit/acls/openstack/designate-dashboard.config b/gerrit/acls/openstack/designate-dashboard.config index bb23dbc85d..cacc249903 100644 --- a/gerrit/acls/openstack/designate-dashboard.config +++ b/gerrit/acls/openstack/designate-dashboard.config @@ -3,6 +3,7 @@ abandon = group designate-core abandon = group horizon-core label-Code-Review = -2..+2 group designate-core label-Code-Review = -2..+2 group horizon-core +label-Review-Priority = -1..+2 group designate-release-manager label-Workflow = -1..+1 group designate-core label-Workflow = -1..+1 group horizon-core @@ -21,6 +22,18 @@ label-Workflow = -1..+1 group Project Bootstrappers label-Workflow = -1..+1 group designate-stable-maint label-Workflow = -1..+1 group horizon-stable-maint +[label "Review-Priority"] +copyAllScoresIfNoCodeChange = true +copyAllScoresOnTrivialRebase = true +copyMaxScore = true +copyMinScore = true +defaultValue = 0 +function = AnyWithBlock +value = -1 Branch Freeze +value = 0 No Priority +value = +1 Important Change +value = +2 Gate Blocker Fix / Urgent Change + [receive] requireChangeId = true requireContributorAgreement = true diff --git a/gerrit/acls/openstack/designate-specs.config b/gerrit/acls/openstack/designate-specs.config index 558c912030..1f14bb59dd 100644 --- a/gerrit/acls/openstack/designate-specs.config +++ b/gerrit/acls/openstack/designate-specs.config @@ -1,8 +1,21 @@ [access "refs/heads/*"] abandon = group designate-core label-Code-Review = -2..+2 group designate-core +label-Review-Priority = -1..+2 group designate-release-manager label-Workflow = -1..+1 group designate-core +[label "Review-Priority"] +copyAllScoresIfNoCodeChange = true +copyAllScoresOnTrivialRebase = true +copyMaxScore = true +copyMinScore = true +defaultValue = 0 +function = AnyWithBlock +value = -1 Branch Freeze +value = 0 No Priority +value = +1 Important Change +value = +2 Gate Blocker Fix / Urgent Change + [receive] requireChangeId = true requireContributorAgreement = true diff --git a/gerrit/acls/openstack/designate-tempest-plugin.config b/gerrit/acls/openstack/designate-tempest-plugin.config index 46d31b1004..6c2278ee6b 100644 --- a/gerrit/acls/openstack/designate-tempest-plugin.config +++ b/gerrit/acls/openstack/designate-tempest-plugin.config @@ -1,9 +1,22 @@ [access "refs/heads/*"] abandon = group designate-tempest-plugin-core label-Code-Review = -2..+2 group designate-tempest-plugin-core +label-Review-Priority = -1..+2 group designate-release-manager label-Verified = -1..+1 group designate-ci label-Workflow = -1..+1 group designate-tempest-plugin-core +[label "Review-Priority"] +copyAllScoresIfNoCodeChange = true +copyAllScoresOnTrivialRebase = true +copyMaxScore = true +copyMinScore = true +defaultValue = 0 +function = AnyWithBlock +value = -1 Branch Freeze +value = 0 No Priority +value = +1 Important Change +value = +2 Gate Blocker Fix / Urgent Change + [receive] requireChangeId = true requireContributorAgreement = true diff --git a/gerrit/acls/openstack/designate.config b/gerrit/acls/openstack/designate.config index a77d2e1855..937f51e97f 100644 --- a/gerrit/acls/openstack/designate.config +++ b/gerrit/acls/openstack/designate.config @@ -1,6 +1,7 @@ [access "refs/heads/*"] abandon = group designate-core label-Code-Review = -2..+2 group designate-core +label-Review-Priority = -1..+2 group designate-release-manager label-Verified = -1..+1 group designate-ci label-Workflow = -1..+1 group designate-core @@ -16,6 +17,18 @@ label-Workflow = -1..+0 group Change Owner label-Workflow = -1..+1 group Project Bootstrappers label-Workflow = -1..+1 group designate-stable-maint +[label "Review-Priority"] +copyAllScoresIfNoCodeChange = true +copyAllScoresOnTrivialRebase = true +copyMaxScore = true +copyMinScore = true +defaultValue = 0 +function = AnyWithBlock +value = -1 Branch Freeze +value = 0 No Priority +value = +1 Important Change +value = +2 Gate Blocker Fix / Urgent Change + [receive] requireChangeId = true requireContributorAgreement = true diff --git a/gerrit/acls/openstack/python-designateclient.config b/gerrit/acls/openstack/python-designateclient.config index e8068b8283..d99bebf40e 100644 --- a/gerrit/acls/openstack/python-designateclient.config +++ b/gerrit/acls/openstack/python-designateclient.config @@ -1,6 +1,7 @@ [access "refs/heads/*"] abandon = group designate-core label-Code-Review = -2..+2 group designate-core +label-Review-Priority = -1..+2 group designate-release-manager label-Workflow = -1..+1 group designate-core [access "refs/heads/stable/*"] @@ -18,6 +19,18 @@ label-Workflow = -1..+1 group designate-milestone [access "refs/tags/*"] pushSignedTag = group library-release +[label "Review-Priority"] +copyAllScoresIfNoCodeChange = true +copyAllScoresOnTrivialRebase = true +copyMaxScore = true +copyMinScore = true +defaultValue = 0 +function = AnyWithBlock +value = -1 Branch Freeze +value = 0 No Priority +value = +1 Important Change +value = +2 Gate Blocker Fix / Urgent Change + [receive] requireChangeId = true requireContributorAgreement = true diff --git a/tools/normalize_acl.py b/tools/normalize_acl.py index bcf49ed16e..05dd03937b 100755 --- a/tools/normalize_acl.py +++ b/tools/normalize_acl.py @@ -58,7 +58,10 @@ out = '' valid_keys = {'abandon', 'access', + 'copyAllScoresIfNoCodeChange', 'copyAllScoresOnTrivialRebase', + 'copyMaxScore', + 'copyMinScore', 'create', 'defaultValue', 'exclusiveGroupPermissions', @@ -66,6 +69,7 @@ valid_keys = {'abandon', 'forgeCommitter', 'function', 'label-Code-Review', + 'label-Review-Priority', 'label-Rollcall-Vote', 'label-Workflow', 'label-Verified',