From c6ef96eec5211092b6b34405117bff65e16165ce Mon Sep 17 00:00:00 2001 From: Joe Gordon Date: Thu, 25 Jul 2013 22:04:25 -0400 Subject: [PATCH] Fix and gate on H302 (import only modules) H302 is already part of the OpenStack style guide, and we only had a few violations. This fixes and gates on H302, so there is one less thing for a reviewer to worry about. gettext import line is ignored using hacking 0.7's import_exceptions option. Reason for import only modules 'The namespace management convention is simple. The source of each identifier is indicated in a consistent way; x.Obj says that object Obj is defined in module x.' http://google-styleguide.googlecode.com/svn/trunk/pyguide.html Change-Id: I53e8039f1dd2ebf8ab5fcf5a561feb3ca3363107 --- tox.ini | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/tox.ini b/tox.ini index b192f2714..2e9cdc47a 100644 --- a/tox.ini +++ b/tox.ini @@ -46,8 +46,9 @@ commands = {posargs} # TODO Hacking 0.6 checks to fix # H102 Apache 2.0 license header not found -ignore = E121,E122,E123,E124,E126,E127,E128,E711,E712,H102,H302,H404,F403,F811,F841 +ignore = E121,E122,E123,E124,E126,E127,E128,E711,E712,H102,H404,F403,F811,F841 exclude = .venv,.git,.tox,dist,doc,*openstack/common*,*lib/python*,*egg,build,*plugins/xenserver*,tools [hacking] local-check-factory = nova.hacking.checks.factory +import_exceptions = nova.openstack.common.gettextutils._