Remove git_dest variables

None of the service_git_dest variables look to have ever been used
anywhere, outside of tempest_git_dest which was removed back in mitaka:
https://review.openstack.org/#/c/341362

Change-Id: I3d6fad8809b968348c30c4b81a59293b7647b94e

playbooks/defaults/repo_packages/gnocchi.yml

@@ -34,5 +34,4 @@
 ## The SHA is recorded here to make the SHA updating easier.
 gnocchi_git_repo: https://git.openstack.org/openstack/gnocchi
 gnocchi_git_install_branch: 1975a9799ccb613e0a4415875a13ca6e3da4abc1 # HEAD of "master" as of 03.03.2017
-gnocchi_git_dest: "/opt/gnocchi_{{ gnocchi_git_install_branch | replace('/', '_') }}"
 gnocchi_git_project_group: gnocchi_all

playbooks/defaults/repo_packages/nova_consoles.yml

@@ -28,12 +28,10 @@
 ## NOVNC from source
 novncproxy_git_repo: https://github.com/kanaka/novnc
 novncproxy_git_install_branch: b56d97524807b125d047730331031ddd00f9c61f # HEAD of "master" as of 03.03.2017
-novncproxy_git_dest: "/opt/novnc_{{ novncproxy_git_install_branch | replace('/', '_') }}"
 novncproxy_git_project_group: nova_console
 
 ## spice-html5 from source
 spicehtml5_git_repo: https://github.com/SPICE/spice-html5
 spicehtml5_git_install_branch: 54cc41299bea8cd681ed0262735e0fd821cd774a # HEAD of "master" as of 03.03.2017
-spicehtml5_git_dest: "/opt/spicehtml5_{{ spicehtml5_git_install_branch | replace('/', '_') }}"
 spicehtml5_git_project_group: nova_console
 

playbooks/defaults/repo_packages/openstack_services.yml

@@ -32,205 +32,173 @@
 ## Global Requirements
 requirements_git_repo: https://git.openstack.org/openstack/requirements
 requirements_git_install_branch: 0ec4a4d4aa3c4bef275484664fa5640d618f74d8 # HEAD of "master" as of 03.03.2017
-requirements_git_dest: "/opt/requirements_{{ requirements_git_install_branch | replace('/', '_') }}"
 
 
 ## Aodh service
 aodh_git_repo: https://git.openstack.org/openstack/aodh
 aodh_git_install_branch: 60ad8b0afcdede263a7151f25a1d8e047d8170bc # HEAD of "master" as of 07.03.2017
-aodh_git_dest: "/opt/aodh_{{ aodh_git_install_branch | replace('/', '_') }}"
 aodh_git_project_group: aodh_all
 
 
 ## Barbican service
 barbican_git_repo: https://git.openstack.org/openstack/barbican
 barbican_git_install_branch: 6752fa23b5801244c85c9021d1f69efb8d539266 # HEAD of "master" as of 03.03.2017
-barbican_git_dest: "/opt/barbican_{{ barbican_git_install_branch | replace('/', '_') }}"
 barbican_git_project_group: barbican_all
 
 
 ## Ceilometer service
 ceilometer_git_repo: https://git.openstack.org/openstack/ceilometer
 ceilometer_git_install_branch: bb9d96286835dc0806dc21ac560b51c16cf34e96 # HEAD of "master" as of 03.03.2017
-ceilometer_git_dest: "/opt/ceilometer_{{ceilometer_git_install_branch | replace('/', '_') }}"
 ceilometer_git_project_group: ceilometer_all
 
 
 ## Cinder service
 cinder_git_repo: https://git.openstack.org/openstack/cinder
 cinder_git_install_branch: 892d5989cf149031cec5563d408ddf28007d88ff # HEAD of "master" as of 03.03.2017
-cinder_git_dest: "/opt/cinder_{{ cinder_git_install_branch | replace('/', '_') }}"
 cinder_git_project_group: cinder_all
 
 
 ## Designate service
 designate_git_repo: https://git.openstack.org/openstack/designate
 designate_git_install_branch: 25758b58e49fae87d86614c93623f09a79be0076 # HEAD of "master" as of 03.03.2017
-designate_git_dest: "/opt/designate_{{ designate_git_install_branch | replace('/', '_') }}"
 designate_git_project_group: designate_all
 
 
 ## Horizon Designate dashboard plugin
 designate_dashboard_git_repo: https://git.openstack.org/openstack/designate-dashboard
 designate_dashboard_git_install_branch: ac7bea44f76d7454b3256ba0a50067142a25edec # HEAD of "master" as of 03.03.2017
-designate_dashboard_git_dest: "/opt/designate_dashboard_{{ designate_dashboard_git_install_branch | replace('/', '_') }}"
 designate_dashboard_git_project_group: horizon_all
 
 
 ## Dragonflow service
 dragonflow_git_repo: https://git.openstack.org/openstack/dragonflow
 dragonflow_git_install_branch: 14a86cd182078b21162f0fedcfab0bd12af1da74 # HEAD of "master" as of 03.03.2017
-dragonflow_git_dest: "/opt/dragonflow_{{ dragonflow_git_install_branch | replace('/', '_') }}"
 dragonflow_git_project_group: neutron_all
 
 
 ## Glance service
 glance_git_repo: https://git.openstack.org/openstack/glance
 glance_git_install_branch: 660a86489fce2ec47a502725922a8d1e03acd892 # HEAD of "master" as of 03.03.2017
-glance_git_dest: "/opt/glance_{{ glance_git_install_branch | replace('/', '_') }}"
 glance_git_project_group: glance_all
 
 
 ## Heat service
 heat_git_repo: https://git.openstack.org/openstack/heat
 heat_git_install_branch: 3c0362e24c21d05dc417ab371e1b4d76178aea36 # HEAD of "master" as of 03.03.2017
-heat_git_dest: "/opt/heat_{{ heat_git_install_branch | replace('/', '_') }}"
 heat_git_project_group: heat_all
 
 
 ## Horizon service
 horizon_git_repo: https://git.openstack.org/openstack/horizon
 horizon_git_install_branch: 5a934f3fe2c04acd7b127f0d0ae0b5639afad27b # HEAD of "master" as of 03.03.2017
-horizon_git_dest: "/opt/horizon_{{ horizon_git_install_branch | replace('/', '_') }}"
 horizon_git_project_group: horizon_all
 
 ## Horizon Ironic dashboard plugin
 ironic_dashboard_git_repo: https://git.openstack.org/openstack/ironic-ui
 ironic_dashboard_git_install_branch: 56f24c031898728e5a1c7cc41507a81f459cfd6d # HEAD of "master" as of 03.03.2017
-ironic_dashboard_git_dest: "/opt/ironic_dashboard_{{ ironic_dashboard_git_install_branch | replace('/', '_') }}"
 ironic_dashboard_git_project_group: horizon_all
 
 ## Horizon Magnum dashboard plugin
 magnum_dashboard_git_repo: https://git.openstack.org/openstack/magnum-ui
 magnum_dashboard_git_install_branch: db6706793934d99eeee79a0da327906e96ca437b # HEAD of "master" as of 03.03.2017
-magnum_dashboard_git_dest: "/opt/magnum_dashboard_{{ magnum_dashboard_git_install_branch | replace('/', '_') }}"
 magnum_dashboard_git_project_group: horizon_all
 
 ## Horizon LBaaS dashboard plugin
 neutron_lbaas_dashboard_git_repo: https://git.openstack.org/openstack/neutron-lbaas-dashboard
 neutron_lbaas_dashboard_git_install_branch: 17da9c283f76cc867a5a6d50d8ce8636b20576d3 # HEAD of "master" as of 03.03.2017
-neutron_lbaas_dashboard_git_dest: "/opt/neutron_lbaas_dashboard_{{ neutron_lbaas_dashboard_git_install_branch | replace('/', '_') }}"
 neutron_lbaas_dashboard_git_project_group: horizon_all
 
 ## Horizon Sahara dashboard plugin
 sahara_dashboard_git_repo: https://git.openstack.org/openstack/sahara-dashboard
 sahara_dashboard_git_install_branch: 4909335ae1b92dea42f73ef2b3acbb1d7b6ac535 # HEAD of "master" as of 03.03.2017
-sahara_dashboard_git_dest: "/opt/sahara_dashboard_{{ sahara_dashboard_git_install_branch | replace('/', '_') }}"
 sahara_dashboard_git_project_group: horizon_all
 
 
 ## Keystone service
 keystone_git_repo: https://git.openstack.org/openstack/keystone
 keystone_git_install_branch: a103486efeefca821ac722cbad6fc31b2e3f133b # HEAD of "master" as of 03.03.2017
-keystone_git_dest: "/opt/keystone_{{ keystone_git_install_branch | replace('/', '_') }}"
 keystone_git_project_group: keystone_all
 
 
 ## Neutron service
 neutron_git_repo: https://git.openstack.org/openstack/neutron
 neutron_git_install_branch: c1a0e6387e971d88ed46136c940fc61c44d9f188 # HEAD of "master" as of 03.03.2017
-neutron_git_dest: "/opt/neutron_{{ neutron_git_install_branch | replace('/', '_') }}"
 neutron_git_project_group: neutron_all
 
 neutron_lbaas_git_repo: https://git.openstack.org/openstack/neutron-lbaas
 neutron_lbaas_git_install_branch: 34e717ca388a8c551f7453aaafed5377be68d1d2 # HEAD of "master" as of 03.03.2017
-neutron_lbaas_git_dest: "/opt/neutron_lbaas_{{ neutron_lbaas_git_install_branch | replace('/', '_') }}"
 neutron_lbaas_git_project_group: neutron_all
 
 neutron_vpnaas_git_repo: https://git.openstack.org/openstack/neutron-vpnaas
 neutron_vpnaas_git_install_branch: da699c24667ab75680ec614eda8b2ad5c5ad8e40 # HEAD of "master" as of 03.03.2017
-neutron_vpnaas_git_dest: "/opt/neutron_vpnaas_{{ neutron_vpnaas_git_install_branch | replace('/', '_') }}"
 neutron_vpnaas_git_project_group: neutron_all
 
 neutron_fwaas_git_repo: https://git.openstack.org/openstack/neutron-fwaas
 neutron_fwaas_git_install_branch: 57ab560d90888dc6dbb0856614db021a70a76dcc # HEAD of "master" as of 03.03.2017
-neutron_fwaas_git_dest: "/opt/neutron_fwaas_{{ neutron_fwaas_git_install_branch | replace('/', '_') }}"
 neutron_fwaas_git_project_group: neutron_all
 
 neutron_dynamic_routing_git_repo: https://git.openstack.org/openstack/neutron-dynamic-routing
 neutron_dynamic_routing_git_install_branch: f7a4b32137674a6f1532c6f6ba09774c658a1d74 # HEAD of "master" as of 03.03.2017
-neutron_dynamic_routing_git_dest: "/opt/neutron_dynamic_routing_{{ neutron_dynamic_routing_git_install_branch | replace('/', '_') }}"
 neutron_dynamic_routing_git_project_group: neutron_all
 
 
 ## Nova service
 nova_git_repo: https://git.openstack.org/openstack/nova
 nova_git_install_branch: e88dd0034b1b135d680dae3494597e295add9cfe # HEAD of "master" as of 03.03.2017
-nova_git_dest: "/opt/nova_{{ nova_git_install_branch | replace('/', '_') }}"
 nova_git_project_group: nova_all
 
 
 ## PowerVM Virt Driver
 nova_powervm_git_repo: https://git.openstack.org/openstack/nova-powervm
 nova_powervm_git_install_branch: dd1d333bfe032c5543c119dcab157b3ee26fe56e # HEAD of "master" as of 03.03.2017
-nova_powervm_git_dest: "/opt/nova_powervm_{{ nova_powervm_git_install_branch | replace('/', '_') }}"
 nova_powervm_git_project_group: nova_compute
 
 
 ## LXD Virt Driver
 nova_lxd_git_repo: https://git.openstack.org/openstack/nova-lxd
 nova_lxd_git_install_branch: df2abbba348668ebd6fef8afff8c7d6355abd8f3 # HEAD of "master" as of 03.03.2017
-nova_lxd_git_dest: "/opt/nova_lxd_{{ nova_lxd_git_install_branch | replace('/', '_') }}"
 nova_lxd_git_project_group: nova_compute
 
 
 ## Sahara service
 sahara_git_repo: https://git.openstack.org/openstack/sahara
 sahara_git_install_branch: 119feff03cba3b8420569ae0a5b599a429bbbe8e # HEAD of "master" as of 03.03.2017
-sahara_git_dest: "/opt/sahara_{{ sahara_git_install_branch | replace('/', '_') }}"
 sahara_git_project_group: sahara_all
 
 
 ## Swift service
 swift_git_repo: https://git.openstack.org/openstack/swift
 swift_git_install_branch: 4cd1e0d697b128e936d0cf9fff900914fdf06cf4 # HEAD of "master" as of 03.03.2017
-swift_git_dest: "/opt/swift_{{ swift_git_install_branch | replace('/', '_') }}"
 swift_git_project_group: swift_all
 
 
 ## Swift3 middleware
 swift3_git_repo: https://git.openstack.org/openstack/swift3
 swift3_git_install_branch: e1598e29d971eaa8855c1e00a72b19ea7d2cd023 # HEAD of "master" as of 15.02.2017
-swift3_git_dest: "/opt/swift3_{{ swift3_git_install_branch | replace('/', '_') }}"
 swift3_git_project_group: swift_all
 
 
 ## Ironic service
 ironic_git_repo: https://git.openstack.org/openstack/ironic
 ironic_git_install_branch: f9ecaca12f7675cf17e84d947b8e5dbf03256005 # HEAD of "master" as of 03.03.2017
-ironic_git_dest: "/opt/ironic_{{ ironic_git_install_branch | replace('/', '_') }}"
 ironic_git_project_group: ironic_all
 
 ## Magnum service
 magnum_git_repo: https://git.openstack.org/openstack/magnum
 magnum_git_install_branch: 9ab31e0d03ff1ed534f6bd757741987a8696e5c8 # HEAD of "master" as of 03.03.2017
-magnum_git_dest: "/opt/magnum_{{ magnum_git_install_branch | replace('/', '_') }}"
 magnum_git_project_group: magnum_all
 
 ## Trove service
 trove_git_repo: https://git.openstack.org/openstack/trove
 trove_git_install_branch: 57148d701d80823add450c9c44d9e9e188cfb946 # HEAD of "master" as of 03.03.2017
-trove_git_dest: "/opt/trove_{{ trove_git_install_branch | replace('/', '_') }}"
 trove_git_project_group: trove_all
 
 ## Horizon Trove dashboard plugin
 trove_dashboard_git_repo: https://git.openstack.org/openstack/trove-dashboard
 trove_dashboard_git_install_branch: a485b5d79f2fcdc8d37cf61f5043c3d3a4a60313 # HEAD of "master" as of 03.03.2017
-trove_dashboard_git_dest: "/opt/trove_dashboard_{{ trove_dashboard_git_install_branch | replace('/', '_') }}"
 trove_dashboard_git_project_group: horizon_all
 
 ## Octavia service
 octavia_git_repo: https://git.openstack.org/openstack/octavia
 octavia_git_install_branch: f7426dcf96874b6e3ce15009d251866f6de01116 # HEAD of "master" as of `28.2.2017
-ocatvia_git_dest: "/opt/octavia_{{ octavia_git_install_branch | replace('/', '_') }}"
 octavia_git_project_group: octavia_all

playbooks/defaults/repo_packages/openstack_testing.yml

@@ -28,7 +28,6 @@
 ## Tempest service
 tempest_git_repo: https://git.openstack.org/openstack/tempest
 tempest_git_install_branch: 9ca8ef195a85258a5a4476cc1f37e070b93c63f1 # HEAD of "master" as of 03.03.2017
-tempest_git_dest: "/opt/tempest_{{ tempest_git_install_branch | replace('/', '_') }}"
 tempest_git_project_group: utility_all
 tempest_git_install_fragments: "venvwithindex=True&ignorerequirements=True"
 
@@ -36,6 +35,5 @@ tempest_git_install_fragments: "venvwithindex=True&ignorerequirements=True"
 ## Rally service
 rally_git_repo: https://git.openstack.org/openstack/rally
 rally_git_install_branch: 9e3ccfa314fc52c9b3062bbe8b2fa78191369c91 # HEAD of "master" as of 03.03.2017
-rally_git_dest: "/opt/rally_{{ rally_git_install_branch | replace('/', '_') }}"
 rally_git_project_group: utility_all
 rally_git_install_fragments: "venvwithindex=True&ignorerequirements=True"

playbooks/defaults/repo_packages/readme.rst

@@ -27,7 +27,6 @@ Repository data can be set in any of the following locations by default.
 The basic structure of all of these files:
   * git_repo: ``string`` URI to the git repository to clone from.
   * git_fallback_repo: ``string`` URI to an alternative git repository to clone from when **git_repo** fails.
-  * git_dest: ``string`` full path to place a cloned git repository. This will normally incorporate the **repo_path** variable for consistency purposes.
   * git_install_branch: ``string`` branch, tag or SHA of a git repository to clone into.
   * git_repo_plugins: ``list`` of ``hashes`` with keys: path, package | This is used to install additional packages which may be installable from the same base repository.
   * git_package_name: ``string`` that will override the "egg" name given for the repo.