db455548a1
The 'force' parameter of os-brick's disconnect_volume() method allows callers to ignore flushing errors and ensure that devices are being removed from the host. We should use force=True when we are going to delete an instance to avoid leaving leftover devices connected to the compute host which could then potentially be reused to map to volumes to an instance that should not have access to those volumes. We can use force=True even when disconnecting a volume that will not be deleted on termination because os-brick will always attempt to flush and disconnect gracefully before forcefully removing devices. Closes-Bug: #2004555 Change-Id: I3629b84d3255a8fe9d8a7cea8c6131d7c40899e8
73 lines
3.2 KiB
Python
73 lines
3.2 KiB
Python
# Copyright (c) 2015 EMC Corporation
|
|
# All Rights Reserved.
|
|
#
|
|
# Licensed under the Apache License, Version 2.0 (the "License"); you may
|
|
# not use this file except in compliance with the License. You may obtain
|
|
# a copy of the License at
|
|
#
|
|
# http://www.apache.org/licenses/LICENSE-2.0
|
|
#
|
|
# Unless required by applicable law or agreed to in writing, software
|
|
# distributed under the License is distributed on an "AS IS" BASIS, WITHOUT
|
|
# WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the
|
|
# License for the specific language governing permissions and limitations
|
|
# under the License.
|
|
|
|
from unittest import mock
|
|
|
|
from nova.tests.unit.virt.libvirt.volume import test_volume
|
|
from nova.virt.libvirt.volume import scaleio
|
|
|
|
|
|
class LibvirtScaleIOVolumeDriverTestCase(
|
|
test_volume.LibvirtVolumeBaseTestCase):
|
|
|
|
@mock.patch('os_brick.initiator.connector.InitiatorConnector.factory',
|
|
new=mock.Mock(return_value=mock.Mock()))
|
|
def test_libvirt_scaleio_driver_connect(self):
|
|
sio = scaleio.LibvirtScaleIOVolumeDriver(self.fake_host)
|
|
disk_info = {'path': '/dev/vol01', 'name': 'vol01'}
|
|
conn = {'data': disk_info}
|
|
sio.connector.connect_volume.return_value = conn['data']
|
|
sio.connect_volume(conn, mock.sentinel.instance)
|
|
sio.connector.connect_volume.assert_called_once_with(conn['data'])
|
|
self.assertEqual(disk_info['path'], conn['data']['device_path'])
|
|
|
|
@mock.patch('os_brick.initiator.connector.InitiatorConnector.factory',
|
|
new=mock.Mock(return_value=mock.Mock()))
|
|
def test_libvirt_scaleio_driver_get_config(self):
|
|
sio = scaleio.LibvirtScaleIOVolumeDriver(self.fake_host)
|
|
conn = {'data': {'device_path': '/dev/vol01'}}
|
|
conf = sio.get_config(conn, self.disk_info)
|
|
self.assertEqual('block', conf.source_type)
|
|
self.assertEqual('/dev/vol01', conf.source_path)
|
|
|
|
@mock.patch('os_brick.initiator.connector.InitiatorConnector.factory',
|
|
new=mock.Mock(return_value=mock.Mock()))
|
|
def test_libvirt_scaleio_driver_disconnect(self):
|
|
sio = scaleio.LibvirtScaleIOVolumeDriver(self.fake_host)
|
|
conn = {'data': mock.sentinel.conn_data}
|
|
sio.disconnect_volume(conn, mock.sentinel.instance)
|
|
sio.connector.disconnect_volume.assert_called_once_with(
|
|
mock.sentinel.conn_data, None, force=False)
|
|
|
|
# Verify force=True
|
|
sio.connector.disconnect_volume.reset_mock()
|
|
sio.disconnect_volume(conn, mock.sentinel.instance, force=True)
|
|
sio.connector.disconnect_volume.assert_called_once_with(
|
|
mock.sentinel.conn_data, None, force=True)
|
|
|
|
@mock.patch('os_brick.initiator.connector.InitiatorConnector.factory',
|
|
new=mock.Mock(return_value=mock.Mock()))
|
|
def test_libvirt_scaleio_driver_extend_volume(self):
|
|
extended_vol_size = 8
|
|
sio = scaleio.LibvirtScaleIOVolumeDriver(self.fake_host)
|
|
disk_info = {'size': extended_vol_size,
|
|
'name': 'vol01',
|
|
'device_path': '/dev/vol01'}
|
|
conn = {'data': disk_info}
|
|
sio.connector.extend_volume.return_value = extended_vol_size
|
|
self.assertEqual(
|
|
extended_vol_size,
|
|
sio.extend_volume(conn, mock.sentinel.instance, extended_vol_size))
|