9db3eba813
This change fixes the get_device_by_alias function to properly handle devices that do not have an alias in the domain xml. By definition if a device does not have an alias it can't match a given alias, so this change adds a hasattr check to ensure we do not attempt to check the alias if it's not defined. This eliminates this entire class of bugs for all devices instead of just fixing it for a specific class. Related-Bug: #1942345 Closes-Bug: #2074219 Change-Id: If417a43ea252647618e50391b63333f6b68bdfec
18 lines
914 B
YAML
18 lines
914 B
YAML
---
|
|
fixes:
|
|
- |
|
|
During the Caracal cycle the libvirt driver was enhanced to support using
|
|
device aliases to detach devices from a domain.
|
|
I1dfe4ad3df81bc810835af9b09cfc6c06e9a5388
|
|
This introduced a regression for instance with vgpus.
|
|
A prior bugfix https://bugs.launchpad.net/nova/+bug/1942345
|
|
addressed the symptom without correcting the underlying problem.
|
|
A related bug for mdev devices was later reported.
|
|
https://bugs.launchpad.net/nova/+bug/2074219
|
|
When this feature was added nova introduced a helper method
|
|
to get device via the alias because the libvirt api does not provide one
|
|
natively. That helper function assumed all devices would have an alias
|
|
attribute. That assumption was not valid and had now been corrected.
|
|
As a result detaching a volume from an instance with vgpus should now
|
|
be possible and this class of bug should no longer happen.
|