From f455cbcbcb70f89f2bdd6a35e9a73343f155b05b Mon Sep 17 00:00:00 2001 From: Joe Gordon Date: Wed, 29 Oct 2014 12:22:29 -0700 Subject: [PATCH] Drop max-complexity to 47 Now that we fixed the two worst offenders, drop the mccabe max-complexity setting in flake8 to 47. Add note explaining how to generate a list of functions that are too 'complex'. Change-Id: I44000e9e95c457ae9000c428460b5825d8ad3f92 --- tox.ini | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/tox.ini b/tox.ini index 8cfc02e5eeca..6fc2ca3b795c 100644 --- a/tox.ini +++ b/tox.ini @@ -60,9 +60,11 @@ commands = python setup.py build_sphinx ignore = E121,E122,E123,E124,E125,E126,E127,E128,E129,E131,E251,H405,H803,H904 exclude = .venv,.git,.tox,dist,doc,*openstack/common*,*lib/python*,*egg,build,tools -# 67 is currently the most complex thing we have +# To get a list of functions that are more complex than 25, set max-complexity +# to 25 and run 'tox -epep8'. +# 46 is currently the most complex thing we have # TODO(jogo): get this number down to 25 or so -max-complexity=68 +max-complexity=47 [hacking] local-check-factory = nova.hacking.checks.factory