From fe933acfc861f9300c5fcfae97fdb4b46b78b9e5 Mon Sep 17 00:00:00 2001 From: Takashi NATSUME Date: Wed, 16 Aug 2017 19:05:38 +0900 Subject: [PATCH] Amend the code review guide for microversion API A new patch for the microversion API change in python-novaclient side should be submitted before the microversion change in Nova is merged. Change-Id: Ie8868a2e767825e08ae4a2e1bfffa7b3fbfb7273 --- doc/source/contributor/code-review.rst | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/doc/source/contributor/code-review.rst b/doc/source/contributor/code-review.rst index 8a8ba5149530..f51fe1828836 100644 --- a/doc/source/contributor/code-review.rst +++ b/doc/source/contributor/code-review.rst @@ -230,7 +230,7 @@ Microversion API If a new microversion API is added, the following needs to happen: * A new patch for the microversion API change in python-novaclient side - should be submitted. + should be submitted before the microversion change in Nova is merged. * If the microversion changes the response schema, a new schema and test for the microversion must be added to Tempest. The microversion change in Nova should not be merged until the Tempest test is submitted and at least