e191ee0a71
Since we don't run pylint in the test tree, things creep
back in. Fixed a number of warnings:
expression-not-assigned
super-with-arguments
useless-object-inheritance
trailing-comma-tuple
undefined-loop-variable
cell-var-from-loop
used-before-assignment
unsubscriptable-object
pointless-statement
confusing-with-statement
Also took the chance to address all the following types
of warnings:
no-value-for-parameter
These were in cases where tests were using a decorator
like @mock.patch or @mock.patch.object, which can confuse
pylint. Luckily you can add a list of signature-mutators
for it to ignore, which is done in a couple of other
repos.
While we are not able to enable pylint for the test tree
quite yet, we are down to ~180 warnings, most being
unnecessary-lambda (~100) and unnecessary-dunder-call (~30).
TrivialFix
Change-Id: I94031c639451b3b4ac00f93052d3a2cd08e08fac
135 lines
3.8 KiB
INI
135 lines
3.8 KiB
INI
# The format of this file isn't really documented; just use --generate-rcfile
|
|
[MAIN]
|
|
# Add <file or directory> to the black list. It should be a base name, not a
|
|
# path. You may set this option multiple times.
|
|
ignore=.git,tests
|
|
|
|
# List of plugins (as comma separated values of python module names) to load,
|
|
# usually to register additional checkers.
|
|
load-plugins=pylint.extensions.no_self_use
|
|
|
|
# When enabled, pylint would attempt to guess common misconfiguration and emit
|
|
# user-friendly hints instead of false-positive error messages.
|
|
suggestion-mode=yes
|
|
|
|
[MESSAGES CONTROL]
|
|
# NOTE(gus): This is a long list. A number of these are important and
|
|
# should be re-enabled once the offending code is fixed (or marked
|
|
# with a local disable)
|
|
disable=
|
|
# "F" Fatal errors that prevent further processing
|
|
import-error,
|
|
# "I" Informational noise
|
|
# "E" Error for important programming issues (likely bugs)
|
|
access-member-before-definition,
|
|
no-member,
|
|
no-method-argument,
|
|
no-self-argument,
|
|
not-an-iterable,
|
|
possibly-used-before-assignment,
|
|
# "W" Warnings for stylistic problems or minor programming issues
|
|
abstract-method,
|
|
arguments-differ,
|
|
attribute-defined-outside-init,
|
|
broad-except,
|
|
fixme,
|
|
global-statement,
|
|
not-callable,
|
|
protected-access,
|
|
redefined-builtin,
|
|
redefined-outer-name,
|
|
signature-differs,
|
|
super-init-not-called,
|
|
unpacking-non-sequence,
|
|
unused-argument,
|
|
unused-import,
|
|
unused-variable,
|
|
unnecessary-pass,
|
|
raise-missing-from,
|
|
arguments-renamed,
|
|
broad-exception-raised,
|
|
unspecified-encoding,
|
|
unused-private-member,
|
|
# "C" Coding convention violations
|
|
consider-iterating-dictionary,
|
|
consider-using-enumerate,
|
|
invalid-name,
|
|
missing-docstring,
|
|
singleton-comparison,
|
|
superfluous-parens,
|
|
ungrouped-imports,
|
|
wrong-import-order,
|
|
consider-using-f-string,
|
|
consider-using-dict-items,
|
|
# "R" Refactor recommendations
|
|
duplicate-code,
|
|
inconsistent-return-statements,
|
|
no-self-use,
|
|
redefined-argument-from-local,
|
|
too-few-public-methods,
|
|
too-many-ancestors,
|
|
too-many-arguments,
|
|
too-many-branches,
|
|
too-many-instance-attributes,
|
|
too-many-lines,
|
|
too-many-locals,
|
|
too-many-nested-blocks,
|
|
too-many-positional-arguments,
|
|
too-many-public-methods,
|
|
too-many-return-statements,
|
|
too-many-statements,
|
|
use-dict-literal
|
|
|
|
[BASIC]
|
|
# Variable names can be 1 to 31 characters long, with lowercase and underscores
|
|
variable-rgx=[a-z_][a-z0-9_]{0,30}$
|
|
|
|
# Argument names can be 2 to 31 characters long, with lowercase and underscores
|
|
argument-rgx=[a-z_][a-z0-9_]{1,30}$
|
|
|
|
# Method names should be at least 3 characters long
|
|
# and be lowercased with underscores
|
|
method-rgx=([a-z_][a-z0-9_]{2,}|setUp|tearDown)$
|
|
|
|
# Module names matching neutron-* are ok (files in bin/)
|
|
module-rgx=(([a-z_][a-z0-9_]*)|([A-Z][a-zA-Z0-9]+)|(neutron-[a-z0-9_-]+))$
|
|
|
|
# Don't require docstrings on tests.
|
|
no-docstring-rgx=((__.*__)|([tT]est.*)|setUp|tearDown)$
|
|
|
|
[FORMAT]
|
|
# Maximum number of characters on a single line.
|
|
max-line-length=79
|
|
|
|
[VARIABLES]
|
|
# List of additional names supposed to be defined in builtins. Remember that
|
|
# you should avoid to define new builtins when possible.
|
|
# _ is used by our localization
|
|
additional-builtins=_
|
|
|
|
[CLASSES]
|
|
# List of valid names for the first argument in a class method.
|
|
valid-classmethod-first-arg=cls
|
|
|
|
# List of valid names for the first argument in a metaclass class method.
|
|
valid-metaclass-classmethod-first-arg=cls
|
|
|
|
[IMPORTS]
|
|
# Deprecated modules which should not be used, separated by a comma
|
|
deprecated-modules=
|
|
# should use oslo_serialization.jsonutils
|
|
json,
|
|
six
|
|
|
|
[TYPECHECK]
|
|
# List of module names for which member attributes should not be checked
|
|
ignored-modules=_MovedItems
|
|
# List of decorators that change the signature of a decorated function
|
|
signature-mutators=
|
|
unittest.mock.patch,
|
|
unittest.mock._patch_object
|
|
|
|
[REPORTS]
|
|
# Tells whether to display a full report or only the messages
|
|
reports=no
|