openstack/ironic
Code Issues Proposed changes

Update Node Cache after Successful Clean/Service

Browse Source 
This commits makes sure we call update_node_cache
after we finish a successful cleaning/servicing.

Change-Id: I62403120c758caac38a4d2b3912a9c43f65161cc
This commit is contained in:
Iury Gregory Melo Ferreira
2024-11-22 08:14:08 -03:00
parent 3421bb614a
commit f6904d9783
3 changed files with 10 additions and 0 deletions
Download Patch File Download Diff File Expand all files Collapse all files

1
ironic/conductor/cleaning.py
View File

@@ -272,6 +272,7 @@ def do_next_clean_step(task, step_index, disable_ramdisk=None):
return utils.cleaning_error_handler(task, msg, return utils.cleaning_error_handler(task, msg,
traceback=True, traceback=True,
tear_down_cleaning=False) tear_down_cleaning=False)
utils.node_update_cache(task)
LOG.info('Node %s cleaning complete', node.uuid) LOG.info('Node %s cleaning complete', node.uuid)
event = 'manage' if manual_clean or node.retired else 'done' event = 'manage' if manual_clean or node.retired else 'done'
# NOTE(rloo): No need to specify target prov. state; we're done # NOTE(rloo): No need to specify target prov. state; we're done

3
ironic/conductor/servicing.py
View File

@@ -55,6 +55,8 @@ def do_node_service(task, service_steps=None, disable_ramdisk=False):
disable_ramdisk) disable_ramdisk)
task.node.save() task.node.save()
utils.node_update_cache(task)
# Allow the deploy driver to set up the ramdisk again (necessary for IPA) # Allow the deploy driver to set up the ramdisk again (necessary for IPA)
try: try:
if not disable_ramdisk: if not disable_ramdisk:
@@ -228,6 +230,7 @@ def _tear_down_node_service(task, disable_ramdisk):
return utils.servicing_error_handler(task, msg, return utils.servicing_error_handler(task, msg,
traceback=True, traceback=True,
tear_down_service=False) tear_down_service=False)
utils.node_update_cache(task)
LOG.info('Node %s service complete.', task.node.uuid) LOG.info('Node %s service complete.', task.node.uuid)
task.process_event('done') task.process_event('done')

6
releasenotes/notes/update-node-cache-after-successful-servicing-cleaning-7433c493e31742b0.yaml Normal file
View File

@@ -0,0 +1,6 @@
---
fixes:
- |
Update the node cache after a successful servicing and cleaning.
This ensures the node information is correctly updated in the
database.