From 2cb3e51dc09783b2cc17e4d6433440518af4a1cf Mon Sep 17 00:00:00 2001 From: Julia Kreger Date: Fri, 5 Sep 2025 06:08:36 -0700 Subject: [PATCH] fix: remove wait logic in pxe filter Ironic has an issue, we don't run pxe filter in its CI so when we removed the wait for start logic which is available and possible with eventlet, we broke the pxe filter. Change-Id: I8ee7ed7167362438da396aed6980a027ceaaaa72 Signed-off-by: Julia Kreger --- ironic/command/pxe_filter.py | 5 ----- .../fix-pxe-filter-post-eventlet-1d12665dbfe11564.yaml | 6 ++++++ 2 files changed, 6 insertions(+), 5 deletions(-) create mode 100644 releasenotes/notes/fix-pxe-filter-post-eventlet-1d12665dbfe11564.yaml diff --git a/ironic/command/pxe_filter.py b/ironic/command/pxe_filter.py index f29c4a01d4..e2bbffd3d6 100644 --- a/ironic/command/pxe_filter.py +++ b/ironic/command/pxe_filter.py @@ -69,11 +69,6 @@ def main(): launcher = service.launch(CONF, mgr, restart_method='mutate') - # NOTE(dtantsur): handling start-up failures before launcher.wait() helps - # notify systemd about them. Otherwise the launcher will report successful - # service start-up before checking the threads. - mgr.wait_for_start() - sys.exit(launcher.wait()) diff --git a/releasenotes/notes/fix-pxe-filter-post-eventlet-1d12665dbfe11564.yaml b/releasenotes/notes/fix-pxe-filter-post-eventlet-1d12665dbfe11564.yaml new file mode 100644 index 0000000000..69b0eb8cb8 --- /dev/null +++ b/releasenotes/notes/fix-pxe-filter-post-eventlet-1d12665dbfe11564.yaml @@ -0,0 +1,6 @@ +--- +fixes: + - | + Fixes ironic's pxe filter logic which some operators may leverage to + restrict access to resources as related to hardware discovery use cases. + The launcher was inadvertently broken during the removal of eventlet.