openstack/ironic
Code Issues Proposed changes

redfish: process inspection rules during inspection

Browse Source 
Include the execution of the inspection rules in the redfish inspector
to behave more like the agent inspector behaves and allow for feature
parity between the two.

Change-Id: Ib0e69d361a7336a3f978d948043d651021ba1061
Signed-off-by: Doug Goldstein <cardoe@cardoe.com>
This commit is contained in:
Doug Goldstein
2025-08-16 13:11:34 -05:00
parent 003603fb5a
commit bb369b6248
3 changed files with 9 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
ironic/drivers/modules/redfish/inspect.py
View File

@@ -20,6 +20,7 @@ import sushy
from ironic.common import boot_modes from ironic.common import boot_modes
from ironic.common import exception from ironic.common import exception
from ironic.common.i18n import _ from ironic.common.i18n import _
from ironic.common.inspection_rules import engine
from ironic.common import states from ironic.common import states
from ironic.common import utils from ironic.common import utils
from ironic.conf import CONF from ironic.conf import CONF
@@ -185,6 +186,7 @@ class RedfishInspect(base.InspectInterface):
inventory, inventory,
plugin_data, plugin_data,
task.context) task.context)
engine.apply_rules(task, inventory, plugin_data, 'main')
valid_keys = self.ESSENTIAL_PROPERTIES valid_keys = self.ESSENTIAL_PROPERTIES
missing_keys = valid_keys - set(inspected_properties) missing_keys = valid_keys - set(inspected_properties)

3
ironic/tests/unit/drivers/modules/redfish/test_inspect.py
View File

@@ -47,7 +47,8 @@ class RedfishInspectTestCase(db_base.DbTestCase):
enabled_management_interfaces=['redfish'], enabled_management_interfaces=['redfish'],
enabled_inspect_interfaces=['redfish']) enabled_inspect_interfaces=['redfish'])
self.node = obj_utils.create_test_node( self.node = obj_utils.create_test_node(
self.context, driver='redfish', driver_info=INFO_DICT) self.context, driver='redfish', driver_info=INFO_DICT,
provision_state=states.MANAGEABLE)
def init_system_mock(self, system_mock, **properties): def init_system_mock(self, system_mock, **properties):

5
releasenotes/notes/redfish-inspection-f8b96425b8758857.yaml Normal file
View File

@@ -0,0 +1,5 @@
---
features:
- |
The redfish inspection interface can now utilize inspection rules as well
as inspection hooks.