We have a lot of import with #noqa that is there to ignore h302, because it's traditional to import and use a name directly, instead of a whole module. This hides other errors and gives people the impression that it's actually fine to import non-modules, you just have to slap #noqa on those lines. I went through the code and identified about a dozen names that are most commonly imported this way. I remove the #noqa tag from them, and added them to the list in import_exceptions. I also removed a few unused imports that were revealed in the process. Change-Id: I27afb8e2b1d4759ec974ded9464d8f010312ee78
112 lines
3.4 KiB
Python
112 lines
3.4 KiB
Python
# vim: tabstop=4 shiftwidth=4 softtabstop=4
|
|
|
|
# Copyright 2013 Rackspace Hosting
|
|
#
|
|
# Licensed under the Apache License, Version 2.0 (the "License"); you may
|
|
# not use this file except in compliance with the License. You may obtain
|
|
# a copy of the License at
|
|
#
|
|
# http://www.apache.org/licenses/LICENSE-2.0
|
|
#
|
|
# Unless required by applicable law or agreed to in writing, software
|
|
# distributed under the License is distributed on an "AS IS" BASIS, WITHOUT
|
|
# WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the
|
|
# License for the specific language governing permissions and limitations
|
|
# under the License.
|
|
|
|
from django.conf import settings
|
|
from django.utils.translation import ugettext_lazy as _
|
|
|
|
from horizon import tabs
|
|
|
|
from openstack_dashboard import api
|
|
from openstack_dashboard.dashboards.project.databases import tables
|
|
|
|
|
|
class OverviewTab(tabs.Tab):
|
|
name = _("Overview")
|
|
slug = "overview"
|
|
template_name = ("project/databases/_detail_overview.html")
|
|
|
|
def get_context_data(self, request):
|
|
return {"instance": self.tab_group.kwargs['instance']}
|
|
|
|
|
|
class UserTab(tabs.TableTab):
|
|
table_classes = [tables.UsersTable]
|
|
name = _("Users")
|
|
slug = "users_tab"
|
|
instance = None
|
|
template_name = "horizon/common/_detail_table.html"
|
|
preload = False
|
|
|
|
def get_users_data(self):
|
|
instance = self.tab_group.kwargs['instance']
|
|
try:
|
|
data = api.trove.users_list(self.request, instance.id)
|
|
for user in data:
|
|
user.instance = instance
|
|
user.access = api.trove.user_list_access(self.request,
|
|
instance.id,
|
|
user.name)
|
|
except Exception:
|
|
data = []
|
|
return data
|
|
|
|
def allowed(self, request):
|
|
perms = getattr(settings, 'TROVE_ADD_USER_PERMS', [])
|
|
if perms:
|
|
return request.user.has_perms(perms)
|
|
return True
|
|
|
|
|
|
class DatabaseTab(tabs.TableTab):
|
|
table_classes = [tables.DatabaseTable]
|
|
name = _("Databases")
|
|
slug = "database_tab"
|
|
instance = None
|
|
template_name = "horizon/common/_detail_table.html"
|
|
preload = False
|
|
|
|
def get_databases_data(self):
|
|
instance = self.tab_group.kwargs['instance']
|
|
try:
|
|
data = api.trove.database_list(self.request, instance.id)
|
|
add_instance = lambda d: setattr(d, 'instance', instance)
|
|
map(add_instance, data)
|
|
except Exception:
|
|
data = []
|
|
return data
|
|
|
|
def allowed(self, request):
|
|
perms = getattr(settings, 'TROVE_ADD_DATABASE_PERMS', [])
|
|
if perms:
|
|
return request.user.has_perms(perms)
|
|
return True
|
|
|
|
|
|
class BackupsTab(tabs.TableTab):
|
|
table_classes = [tables.InstanceBackupsTable]
|
|
name = _("Backups")
|
|
slug = "backups_tab"
|
|
instance = None
|
|
template_name = "horizon/common/_detail_table.html"
|
|
preload = False
|
|
|
|
def get_backups_data(self):
|
|
instance = self.tab_group.kwargs['instance']
|
|
try:
|
|
data = api.trove.instance_backups(self.request, instance.id)
|
|
except Exception:
|
|
data = []
|
|
return data
|
|
|
|
def allowed(self, request):
|
|
return request.user.has_perm('openstack.services.object-store')
|
|
|
|
|
|
class InstanceDetailTabs(tabs.TabGroup):
|
|
slug = "instance_details"
|
|
tabs = (OverviewTab, UserTab, DatabaseTab, BackupsTab)
|
|
sticky = True
|