From bc98bb38fe2e9c3246a087af605d4716b8b9359b Mon Sep 17 00:00:00 2001
From: Bartosz Woronicz <bartosz.woronicz@canonical.com>
Date: Wed, 7 Apr 2021 16:30:19 +0200
Subject: [PATCH] rename options to proper and add missing options

---
 config.yaml              | 12 +++++++++++-
 unit_tests/test_charm.py |  4 +++-
 2 files changed, 14 insertions(+), 2 deletions(-)

diff --git a/config.yaml b/config.yaml
index 43d91b2..1989264 100644
--- a/config.yaml
+++ b/config.yaml
@@ -1,5 +1,5 @@
 options:
-  debug:
+  hpe3par-debug:
     type: boolean
     default: False
     description: |
@@ -31,6 +31,16 @@ options:
     default: 72
     description: |
       Time in hours a snapshot cannot be deleted.
+  max-over-subscription-ratio:
+    type: float
+    default: 20.0
+    description: |
+      The ratio of oversubscription when thin provisioned volumes are involved.
+  reserved-percentage:
+    type: int
+    default: 15
+    description: |
+      This flag represents the percentage of reserved back-end capacity
   san-ip:
     type: string
     description: | 
diff --git a/unit_tests/test_charm.py b/unit_tests/test_charm.py
index 19711e9..1d459ae 100644
--- a/unit_tests/test_charm.py
+++ b/unit_tests/test_charm.py
@@ -12,12 +12,14 @@ TEST_3PAR_CONFIG = '\
 {"/etc/cinder/cinder.conf": \
 {"sections": \
 {"charm-cinder-three-par": \
-[["debug", false], \
+[["hpe3par_debug", false], \
 ["driver_type", "fc"], \
 ["hpe3par_iscsi_ips", ""], \
 ["hpe3par_iscsi_chap_enabled", true], \
 ["hpe3par_snapshot_expiration", 48], \
 ["hpe3par_snapshot_retention", 72], \
+["max_over_subscription_ratio", 20.0], \
+["reserved_percentage", 15], \
 ["san_ip", "1.2.3.4"], \
 ["san_login", "login"], \
 ["san_password", "pwd"], \