From 47ddb67cb5d6a4b83a6706e94cb3c123e6a0b446 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Stanis=C5=82aw=20Pitucha?= Date: Thu, 5 Nov 2015 16:47:51 +1100 Subject: [PATCH] Test for bug 1513091 Add a test for case with constructed subprocess call. Change-Id: If62c04afdb0f19bab3d9ba87ce0c40a0a3e24739 --- examples/subprocess_shell.py | 3 +++ tests/functional/test_functional.py | 4 ++-- 2 files changed, 5 insertions(+), 2 deletions(-) diff --git a/examples/subprocess_shell.py b/examples/subprocess_shell.py index 038e8eb8..3ce96674 100644 --- a/examples/subprocess_shell.py +++ b/examples/subprocess_shell.py @@ -26,3 +26,6 @@ subprocess.check_output('/bin/ls -l', shell=True) subprocess.Popen('/bin/ls *', shell=True) subprocess.Popen('/bin/ls %s' % ('something',), shell=True) subprocess.Popen('/bin/ls {}'.format('something'), shell=True) + +command = "/bin/ls" + unknown_function() +subprocess.Popen(command, shell=True) diff --git a/tests/functional/test_functional.py b/tests/functional/test_functional.py index 469be20d..2d1d588b 100644 --- a/tests/functional/test_functional.py +++ b/tests/functional/test_functional.py @@ -297,8 +297,8 @@ class FunctionalTests(testtools.TestCase): def test_subprocess_shell(self): '''Test for `subprocess.Popen` with `shell=True`.''' expect = { - 'SEVERITY': {'HIGH': 2, 'MEDIUM': 2, 'LOW': 12}, - 'CONFIDENCE': {'HIGH': 16} + 'SEVERITY': {'HIGH': 3, 'MEDIUM': 2, 'LOW': 12}, + 'CONFIDENCE': {'HIGH': 17} } self.check_example('subprocess_shell.py', expect)