opendev/puppet-storyboard
Code Issues Proposed changes

Use versioncmp function

Browse Source 
Puppet 4 is more strict about data types and doesn't tolerate using
arithmetic operators on strings. The operatingsystemrelease fact is a
string. Switch the arithmetic comparison to a native function that knows
how to deal with version numbers.

Change-Id: I98d5b4c50b26b5ea64035d726d903900c2040b99
This commit is contained in:
Colleen Murphy
2018-04-26 21:37:44 +02:00
parent 85896f5c03
commit 8fd663a697
1 changed files with 1 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
manifests/params.pp
View File

@@ -25,7 +25,7 @@ class storyboard::params () {
case $::osfamily { case $::osfamily {
'Debian': { 'Debian': {
if $::operatingsystem == 'Ubuntu' and $::operatingsystemrelease >= 13.10 { if $::operatingsystem == 'Ubuntu' and versioncmp($::operatingsystemrelease, '13.10') >= 0 {
$apache_version = '2.4' $apache_version = '2.4'
$manage_rabbit_repo = false $manage_rabbit_repo = false
} else { } else {