4a8b93b8c2
The goal of this patch is simply to move some classes out of jenkins_jobs.builder into more appropriately-named modules. This started with simply moving YamlParser into jenkins_jobs.parser but led to other moves in order to avoid cyclic imports since YamlParser uses other classes previously defined in jenkins_jobs.builder. That said, this patch doesn't intend to address all of the clutter in jenkins_jobs.builder, mostly just what is necessary to get started working on YamlParser independent of other classes in that module. Change-Id: Ie88bf683e495033eb0b670fe29c256a70282735f
267 lines
10 KiB
Python
267 lines
10 KiB
Python
import os
|
|
import io
|
|
import codecs
|
|
import yaml
|
|
|
|
import jenkins
|
|
|
|
from jenkins_jobs import cmd
|
|
from jenkins_jobs.errors import JenkinsJobsException
|
|
from tests.base import mock
|
|
from tests.cmd.test_cmd import CmdTestsBase
|
|
from tests.cmd.test_recurse_path import fake_os_walk
|
|
|
|
|
|
os_walk_return_values = {
|
|
'/jjb_projects': [
|
|
('/jjb_projects', (['dir1', 'dir2', 'dir3'], ())),
|
|
('/jjb_projects/dir1', (['bar'], ())),
|
|
('/jjb_projects/dir2', (['baz'], ())),
|
|
('/jjb_projects/dir3', ([], ())),
|
|
('/jjb_projects/dir1/bar', ([], ())),
|
|
('/jjb_projects/dir2/baz', ([], ())),
|
|
],
|
|
'/jjb_templates': [
|
|
('/jjb_templates', (['dir1', 'dir2', 'dir3'], ())),
|
|
('/jjb_templates/dir1', (['bar'], ())),
|
|
('/jjb_templates/dir2', (['baz'], ())),
|
|
('/jjb_templates/dir3', ([], ())),
|
|
('/jjb_templates/dir1/bar', ([], ())),
|
|
('/jjb_templates/dir2/baz', ([], ())),
|
|
],
|
|
'/jjb_macros': [
|
|
('/jjb_macros', (['dir1', 'dir2', 'dir3'], ())),
|
|
('/jjb_macros/dir1', (['bar'], ())),
|
|
('/jjb_macros/dir2', (['baz'], ())),
|
|
('/jjb_macros/dir3', ([], ())),
|
|
('/jjb_macros/dir1/bar', ([], ())),
|
|
('/jjb_macros/dir2/baz', ([], ())),
|
|
],
|
|
}
|
|
|
|
|
|
def os_walk_side_effects(path_name, topdown):
|
|
return fake_os_walk(os_walk_return_values[path_name])(path_name, topdown)
|
|
|
|
|
|
@mock.patch('jenkins_jobs.builder.Jenkins.get_plugins_info', mock.MagicMock)
|
|
class TestTests(CmdTestsBase):
|
|
|
|
def test_non_existing_config_dir(self):
|
|
"""
|
|
Run test mode and pass a non-existing configuration directory
|
|
"""
|
|
args = self.parser.parse_args(['test', 'foo'])
|
|
self.assertRaises(IOError, cmd.execute, args, self.config)
|
|
|
|
def test_non_existing_config_file(self):
|
|
"""
|
|
Run test mode and pass a non-existing configuration file
|
|
"""
|
|
args = self.parser.parse_args(['test', 'non-existing.yaml'])
|
|
self.assertRaises(IOError, cmd.execute, args, self.config)
|
|
|
|
def test_non_existing_job(self):
|
|
"""
|
|
Run test mode and pass a non-existing job name
|
|
(probably better to fail here)
|
|
"""
|
|
args = self.parser.parse_args(['test',
|
|
os.path.join(self.fixtures_path,
|
|
'cmd-001.yaml'),
|
|
'invalid'])
|
|
args.output_dir = mock.MagicMock()
|
|
cmd.execute(args, self.config) # probably better to fail here
|
|
|
|
def test_valid_job(self):
|
|
"""
|
|
Run test mode and pass a valid job name
|
|
"""
|
|
args = self.parser.parse_args(['test',
|
|
os.path.join(self.fixtures_path,
|
|
'cmd-001.yaml'),
|
|
'foo-job'])
|
|
args.output_dir = mock.MagicMock()
|
|
cmd.execute(args, self.config) # probably better to fail here
|
|
|
|
@mock.patch('jenkins_jobs.cmd.Builder.update_job')
|
|
def test_multi_path(self, update_job_mock):
|
|
"""
|
|
Run test mode and pass multiple paths.
|
|
"""
|
|
path_list = list(os_walk_return_values.keys())
|
|
multipath = os.pathsep.join(path_list)
|
|
|
|
args = self.parser.parse_args(['test', multipath])
|
|
args.output_dir = mock.MagicMock()
|
|
|
|
cmd.execute(args, self.config)
|
|
self.assertEqual(args.path, path_list)
|
|
update_job_mock.assert_called_with(path_list, [],
|
|
output=args.output_dir)
|
|
|
|
@mock.patch('jenkins_jobs.cmd.Builder.update_job')
|
|
@mock.patch('jenkins_jobs.cmd.os.path.isdir')
|
|
@mock.patch('jenkins_jobs.cmd.os.walk')
|
|
def test_recursive_multi_path(self, os_walk_mock, isdir_mock,
|
|
update_job_mock):
|
|
"""
|
|
Run test mode and pass multiple paths with recursive path option.
|
|
"""
|
|
|
|
os_walk_mock.side_effect = os_walk_side_effects
|
|
isdir_mock.return_value = True
|
|
|
|
path_list = os_walk_return_values.keys()
|
|
paths = []
|
|
for path in path_list:
|
|
paths.extend([p for p, _ in os_walk_return_values[path]])
|
|
|
|
multipath = os.pathsep.join(path_list)
|
|
|
|
args = self.parser.parse_args(['test', '-r', multipath])
|
|
args.output_dir = mock.MagicMock()
|
|
|
|
cmd.execute(args, self.config)
|
|
|
|
update_job_mock.assert_called_with(paths, [], output=args.output_dir)
|
|
|
|
args = self.parser.parse_args(['test', multipath])
|
|
self.config.set('job_builder', 'recursive', 'True')
|
|
cmd.execute(args, self.config)
|
|
|
|
update_job_mock.assert_called_with(paths, [], output=args.output_dir)
|
|
|
|
@mock.patch('jenkins_jobs.cmd.Builder.update_job')
|
|
@mock.patch('jenkins_jobs.cmd.os.path.isdir')
|
|
@mock.patch('jenkins_jobs.cmd.os.walk')
|
|
def test_recursive_multi_path_with_excludes(self, os_walk_mock, isdir_mock,
|
|
update_job_mock):
|
|
"""
|
|
Run test mode and pass multiple paths with recursive path option.
|
|
"""
|
|
|
|
os_walk_mock.side_effect = os_walk_side_effects
|
|
isdir_mock.return_value = True
|
|
|
|
path_list = os_walk_return_values.keys()
|
|
paths = []
|
|
for path in path_list:
|
|
paths.extend([p for p, __ in os_walk_return_values[path]
|
|
if 'dir1' not in p and 'dir2' not in p])
|
|
|
|
multipath = os.pathsep.join(path_list)
|
|
|
|
args = self.parser.parse_args(['test', '-r', multipath, '-x',
|
|
'dir1:dir2'])
|
|
args.output_dir = mock.MagicMock()
|
|
|
|
cmd.execute(args, self.config)
|
|
|
|
update_job_mock.assert_called_with(paths, [], output=args.output_dir)
|
|
|
|
def test_console_output(self):
|
|
"""
|
|
Run test mode and verify that resulting XML gets sent to the console.
|
|
"""
|
|
|
|
console_out = io.BytesIO()
|
|
with mock.patch('sys.stdout', console_out):
|
|
cmd.main(['test', os.path.join(self.fixtures_path,
|
|
'cmd-001.yaml')])
|
|
xml_content = codecs.open(os.path.join(self.fixtures_path,
|
|
'cmd-001.xml'),
|
|
'r', 'utf-8').read()
|
|
self.assertEqual(console_out.getvalue().decode('utf-8'), xml_content)
|
|
|
|
def test_config_with_test(self):
|
|
"""
|
|
Run test mode and pass a config file
|
|
"""
|
|
args = self.parser.parse_args(['--conf',
|
|
os.path.join(self.fixtures_path,
|
|
'cmd-001.conf'),
|
|
'test',
|
|
os.path.join(self.fixtures_path,
|
|
'cmd-001.yaml'),
|
|
'foo-job'])
|
|
config = cmd.setup_config_settings(args)
|
|
self.assertEqual(config.get('jenkins', 'url'),
|
|
"http://test-jenkins.with.non.default.url:8080/")
|
|
|
|
@mock.patch('jenkins_jobs.builder.YamlParser.generateXML')
|
|
@mock.patch('jenkins_jobs.parser.ModuleRegistry')
|
|
def test_plugins_info_stub_option(self, registry_mock, generateXML_mock):
|
|
"""
|
|
Test handling of plugins_info stub option.
|
|
"""
|
|
plugins_info_stub_yaml_file = os.path.join(self.fixtures_path,
|
|
'plugins-info.yaml')
|
|
args = ['--conf',
|
|
os.path.join(self.fixtures_path, 'cmd-001.conf'),
|
|
'test',
|
|
'-p',
|
|
plugins_info_stub_yaml_file,
|
|
os.path.join(self.fixtures_path, 'cmd-001.yaml')]
|
|
args = self.parser.parse_args(args)
|
|
|
|
with mock.patch('sys.stdout'):
|
|
cmd.execute(args, self.config) # probably better to fail here
|
|
|
|
with open(plugins_info_stub_yaml_file, 'r') as yaml_file:
|
|
plugins_info_list = yaml.load(yaml_file)
|
|
|
|
registry_mock.assert_called_with(self.config, plugins_info_list)
|
|
|
|
@mock.patch('jenkins_jobs.builder.YamlParser.generateXML')
|
|
@mock.patch('jenkins_jobs.parser.ModuleRegistry')
|
|
def test_bogus_plugins_info_stub_option(self, registry_mock,
|
|
generateXML_mock):
|
|
"""
|
|
Verify that a JenkinsJobException is raised if the plugins_info stub
|
|
file does not yield a list as its top-level object.
|
|
"""
|
|
plugins_info_stub_yaml_file = os.path.join(self.fixtures_path,
|
|
'bogus-plugins-info.yaml')
|
|
args = ['--conf',
|
|
os.path.join(self.fixtures_path, 'cmd-001.conf'),
|
|
'test',
|
|
'-p',
|
|
plugins_info_stub_yaml_file,
|
|
os.path.join(self.fixtures_path, 'cmd-001.yaml')]
|
|
args = self.parser.parse_args(args)
|
|
|
|
with mock.patch('sys.stdout'):
|
|
e = self.assertRaises(JenkinsJobsException, cmd.execute,
|
|
args, self.config)
|
|
self.assertIn("must contain a Yaml list", str(e))
|
|
|
|
|
|
class TestJenkinsGetPluginInfoError(CmdTestsBase):
|
|
""" This test class is used for testing the 'test' subcommand when we want
|
|
to validate its behavior without mocking
|
|
jenkins_jobs.builder.Jenkins.get_plugins_info
|
|
"""
|
|
|
|
@mock.patch('jenkins.Jenkins.get_plugins_info')
|
|
def test_console_output_jenkins_connection_failure_warning(
|
|
self, get_plugins_info_mock):
|
|
"""
|
|
Run test mode and verify that failed Jenkins connection attempt
|
|
exception does not bubble out of cmd.main. Ideally, we would also test
|
|
that an appropriate message is logged to stderr but it's somewhat
|
|
difficult to figure out how to actually enable stderr in this test
|
|
suite.
|
|
"""
|
|
|
|
get_plugins_info_mock.side_effect = \
|
|
jenkins.JenkinsException("Connection refused")
|
|
with mock.patch('sys.stdout'):
|
|
try:
|
|
cmd.main(['test', os.path.join(self.fixtures_path,
|
|
'cmd-001.yaml')])
|
|
except jenkins.JenkinsException:
|
|
self.fail("jenkins.JenkinsException propagated to main")
|
|
except:
|
|
pass # only care about jenkins.JenkinsException for now
|